Remove host restrictions from snippets

Remove host restrictions from snippets

They were only supported in chrome://snippets-internals, and are now
removed there too.

Note that, if a user somehow manages to issue an interactive request
before the snippets service reports itself as ready, we schedule a
request for later, which will be marked as non-interactive.

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b19e566077e57c2e04de0bcf391e35eff8fd1e8d
Cr-Commit-Position: refs/heads/master@{#438482}

[sfiera, 2016-12-13 12:15:41]

Description was changed from

==========
Remove host restrictions from snippets API

BUG=648567
==========

to

==========
Remove host restrictions from snippets API

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sfiera, 2016-12-13 12:16:05]

Description was changed from

==========
Remove host restrictions from snippets API

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove host restrictions from snippets

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sfiera, 2016-12-13 12:22:33]

Description was changed from

==========
Remove host restrictions from snippets

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove host restrictions from snippets

They were only supported in chrome://snippets-internals, and are now
removed there too.

Note that, if a user somehow manages to issue an interactive request
before the snippets service reports itself as ready, we schedule a
request for later, which will be marked as non-interactive.

BUG=648567
==========

[sfiera, 2016-12-13 12:23:02]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[sfiera, 2016-12-13 12:23:02]

My favorite kind of CL

[Marc Treib, 2016-12-13 13:27:49]

lgtm

Yay, mine too! Deleted code is best code!

https://codereview.chromium.org/2570673004/diff/20001/components/ntp_snippets...
File components/ntp_snippets/remote/ntp_snippets_fetcher.cc (right):

https://codereview.chromium.org/2570673004/diff/20001/components/ntp_snippets...
components/ntp_snippets/remote/ntp_snippets_fetcher.cc:725:
std::move(content_selectors));
I think this can now be removed?

[sfiera, 2016-12-13 13:41:39]

Description was changed from

==========
Remove host restrictions from snippets

They were only supported in chrome://snippets-internals, and are now
removed there too.

Note that, if a user somehow manages to issue an interactive request
before the snippets service reports itself as ready, we schedule a
request for later, which will be marked as non-interactive.

BUG=648567
==========

to

==========
Remove host restrictions from snippets

They were only supported in chrome://snippets-internals, and are now
removed there too.

Note that, if a user somehow manages to issue an interactive request
before the snippets service reports itself as ready, we schedule a
request for later, which will be marked as non-interactive.

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sfiera, 2016-12-13 13:41:57]

https://codereview.chromium.org/2570673004/diff/20001/components/ntp_snippets...
File components/ntp_snippets/remote/ntp_snippets_fetcher.cc (right):

https://codereview.chromium.org/2570673004/diff/20001/components/ntp_snippets...
components/ntp_snippets/remote/ntp_snippets_fetcher.cc:725:
std::move(content_selectors));
On 2016/12/13 13:27:49, Marc Treib wrote:
> I think this can now be removed?

Done.

[sfiera, 2016-12-13 13:42:03]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-12-13 13:42:03]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2570673004/#ps40001
(title: "Remove unneeded code")

[commit-bot: I haz the power, 2016-12-13 13:42:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 13:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 13:46:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[sfiera, 2016-12-13 16:02:45]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 16:03:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 16:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 16:05:44]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sfiera, 2016-12-13 16:11:23]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 16:11:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sfiera, 2016-12-13 16:36:17]

The CQ bit was unchecked by sfiera@chromium.org

[sfiera, 2016-12-13 16:36:18]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-12-13 16:36:18]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2570673004/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-13 16:36:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 16:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 16:44:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sfiera, 2016-12-14 10:17:44]

sfiera@chromium.org changed reviewers:
+ bauerb@chromium.org

[sfiera, 2016-12-14 10:17:45]

+bauerb for webui as usual, thanks!

[sfiera, 2016-12-14 10:30:32]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 10:30:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-12-14 10:59:36]

webui LGTM

[sfiera, 2016-12-14 11:02:30]

The CQ bit was unchecked by sfiera@chromium.org

[sfiera, 2016-12-14 11:02:31]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-12-14 11:02:31]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2570673004/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-14 11:02:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 11:40:46]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481713351347370,
"parent_rev": "e57f6a0ee0ffe7ec142307e3e7d04241db56c5c9", "commit_rev":
"7b3074f757ec6af38afc79efa6bb6735893ccbd5"}

[commit-bot: I haz the power, 2016-12-14 11:41:12]

Description was changed from

==========
Remove host restrictions from snippets

They were only supported in chrome://snippets-internals, and are now
removed there too.

Note that, if a user somehow manages to issue an interactive request
before the snippets service reports itself as ready, we schedule a
request for later, which will be marked as non-interactive.

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove host restrictions from snippets

They were only supported in chrome://snippets-internals, and are now
removed there too.

Note that, if a user somehow manages to issue an interactive request
before the snippets service reports itself as ready, we schedule a
request for later, which will be marked as non-interactive.

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570673004
==========

[commit-bot: I haz the power, 2016-12-14 11:41:13]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-14 11:42:42]

Description was changed from

==========
Remove host restrictions from snippets

They were only supported in chrome://snippets-internals, and are now
removed there too.

Note that, if a user somehow manages to issue an interactive request
before the snippets service reports itself as ready, we schedule a
request for later, which will be marked as non-interactive.

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570673004
==========

to

==========
Remove host restrictions from snippets

They were only supported in chrome://snippets-internals, and are now
removed there too.

Note that, if a user somehow manages to issue an interactive request
before the snippets service reports itself as ready, we schedule a
request for later, which will be marked as non-interactive.

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b19e566077e57c2e04de0bcf391e35eff8fd1e8d
Cr-Commit-Position: refs/heads/master@{#438482}
==========

[commit-bot: I haz the power, 2016-12-14 11:42:43]

Patchset 6 (id:??) landed as
https://crrev.com/b19e566077e57c2e04de0bcf391e35eff8fd1e8d
Cr-Commit-Position: refs/heads/master@{#438482}