Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2570623004: [Mac] Guard against null memory pressure dispatch source (Closed)

Created:
4 years ago by lgrey
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Guard against null memory pressure dispatch source BUG=673822 Committed: https://crrev.com/d3eb66287d102d4fa4f8750e39ec4d1eb97c3b71 Cr-Commit-Position: refs/heads/master@{#438317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M base/memory/memory_pressure_monitor_mac.cc View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
lgrey
This is a speculative fix for the attached bug. I can't repro on a 10.9.5 ...
4 years ago (2016-12-13 20:57:15 UTC) #2
Robert Sesek
Can the reporter repro this on current canary? If so, then we can land this ...
4 years ago (2016-12-13 21:03:02 UTC) #3
Robert Sesek
LGTM based on https://crbug.com/673822#c8 though.
4 years ago (2016-12-13 21:16:35 UTC) #4
lgrey
+mark@ for base OWNERS
4 years ago (2016-12-13 21:22:08 UTC) #6
Mark Mentovai
LGTM
4 years ago (2016-12-13 21:43:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570623004/1
4 years ago (2016-12-13 21:56:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 22:42:26 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 22:43:58 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3eb66287d102d4fa4f8750e39ec4d1eb97c3b71
Cr-Commit-Position: refs/heads/master@{#438317}

Powered by Google App Engine
This is Rietveld 408576698