[Chromecast] Turn CastContentWindow into an abstract interface.

chromecast/browser/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//chromecast/chromecast.gni")
 import("//testing/test.gni")
 import("//tools/grit/grit_rule.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
 source_set("browser") {
   sources = [
-    "android/cast_window_android.cc",
-    "android/cast_window_android.h",
-    "android/cast_window_manager.cc",
-    "android/cast_window_manager.h",
     "cast_browser_context.cc",
     "cast_browser_context.h",
     "cast_browser_main_parts.cc",
     "cast_browser_main_parts.h",
     "cast_browser_process.cc",
     "cast_browser_process.h",
     "cast_content_browser_client.cc",
     "cast_content_browser_client.h",
-    "cast_content_window.cc",
     "cast_content_window.h",
     "cast_download_manager_delegate.cc",
     "cast_download_manager_delegate.h",
     "cast_http_user_agent_settings.cc",
     "cast_http_user_agent_settings.h",
     "cast_media_blocker.cc",
     "cast_media_blocker.h",
     "cast_net_log.cc",
     "cast_net_log.h",
     "cast_network_delegate.cc",
@@ skipping 77 matching lines @@
     "//media",
     "//net",
     "//ui/base",
     "//ui/compositor",
     "//ui/display",
     "//ui/gl",
   ]
 
   if (is_linux) {
     sources += [
+      "cast_content_window_linux.cc",
+      "cast_content_window_linux.h",

[byungchul, 2016/12/16 22:52:22]

In the past, gyp file specified all files and let ninja pick platform-specific
files accordingly. Is it changed for BUILD.gn?

[derekjchow1, 2016/12/17 00:13:07]

It's not changed but it's not well known either. I've been bitten by this
behaviour before actually (I though an internal file named *_linux file could be
included in an android build).

My preference is to be explicit and leave them in these if statements, rather
than depend on the BUILD.gn behaviour.

       "cast_memory_pressure_monitor.cc",
       "cast_memory_pressure_monitor.h",
       "metrics/external_metrics.cc",
       "metrics/external_metrics.h",
     ]
 
     deps += [
       "//build/linux:fontconfig",
       "//components/metrics:serialization",
       "//ui/aura",
     ]
   } else if (is_android) {
+    sources += [
+      "android/cast_content_window_android.cc",
+      "android/cast_content_window_android.h",
+      "android/cast_web_contents_activity.cc",
+      "android/cast_web_contents_activity.h",
+    ]
+
     deps += [ ":jni_headers" ]
   }
 
   if (use_ozone) {
     deps += [ "//ui/ozone" ]
   }
 }
 
 grit("resources") {
   visibility = [
@@ skipping 59 matching lines @@
     "//base",
     "//chromecast/base",
     "//content/public/browser",
     "//content/test:test_support",
   ]
 }
 
 if (is_android) {
   generate_jni("jni_headers") {
     sources = [
+      "android/apk/src/org/chromium/chromecast/shell/CastContentWindowAndroid.java",
       "android/apk/src/org/chromium/chromecast/shell/CastCrashHandler.java",
       "android/apk/src/org/chromium/chromecast/shell/CastMetricsHelper.java",
       "android/apk/src/org/chromium/chromecast/shell/CastSysInfoAndroid.java",
-      "android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java",
-      "android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java",
+      "android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java",
     ]
 
     jni_package = "chromecast"
   }
 }