Add OffscreenCanvas to ImageBitmapSource union typedef

Add OffscreenCanvas to ImageBitmapSource union typedef

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
TBR=haraken@chromium.org

Committed: https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145
Cr-Commit-Position: refs/heads/master@{#438617}

[Justin Novosad, 2016-12-12 18:34:34]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 18:35:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2016-12-12 18:35:17]

junov@chromium.org changed reviewers:
+ senorblanco@google.com

[Justin Novosad, 2016-12-12 18:35:18]

PTAL

[commit-bot: I haz the power, 2016-12-12 18:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 18:55:22]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Stephen White, 2016-12-12 19:55:45]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2016-12-12 19:55:46]

LGTM w/nit (and modulo bot unhappiness)

https://codereview.chromium.org/2570613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/security/offscreencanvas-read-blocked-no-crossorigin.html
(right):

https://codereview.chromium.org/2570613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/security/offscreencanvas-read-blocked-no-crossorigin.html:53:
}, "Verify that createImageBitmap(OffscreenCanvas) propagates th origin-clean
flag.");
Nit: th -> the

[Justin Novosad, 2016-12-12 20:21:31]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2016-12-12 20:21:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/2570613002/#ps20001
(title: "fix build + comment")

[commit-bot: I haz the power, 2016-12-12 20:22:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 21:58:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 21:58:29]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Justin Novosad, 2016-12-14 15:34:18]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2016-12-14 15:34:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/2570613002/#ps40001
(title: "rebase results")

[commit-bot: I haz the power, 2016-12-14 15:34:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2016-12-14 15:34:57]

Description was changed from

==========
Add OffscreenCanvas to ImageBitmapSource union typedef

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
==========

to

==========
Add OffscreenCanvas to ImageBitmapSource union typedef

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
TBR=haraken
==========

[Justin Novosad, 2016-12-14 15:35:09]

Description was changed from

==========
Add OffscreenCanvas to ImageBitmapSource union typedef

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
TBR=haraken
==========

to

==========
Add OffscreenCanvas to ImageBitmapSource union typedef

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
TBR=haraken@chromium.org
==========

[Justin Novosad, 2016-12-14 15:36:15]

TBR-ing haraken for trivial change to Source/bindings/core/v8/BUILD.gn

[haraken, 2016-12-14 15:36:42]

On 2016/12/14 15:36:15, Justin Novosad wrote:
> TBR-ing haraken for trivial change to Source/bindings/core/v8/BUILD.gn

LGTM

[commit-bot: I haz the power, 2016-12-14 15:45:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 15:45:58]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Justin Novosad, 2016-12-14 19:09:51]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2016-12-14 19:09:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/2570613002/#ps60001
(title: "build fix")

[commit-bot: I haz the power, 2016-12-14 19:10:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 20:52:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481742591276290,
"parent_rev": "eb15b1e457ac4eff5527c550e121deda893e6cb5", "commit_rev":
"dd801f83df42cc4143b334fd521ffbc990a68797"}

[commit-bot: I haz the power, 2016-12-14 20:53:44]

Description was changed from

==========
Add OffscreenCanvas to ImageBitmapSource union typedef

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
TBR=haraken@chromium.org
==========

to

==========
Add OffscreenCanvas to ImageBitmapSource union typedef

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2570613002
==========

[commit-bot: I haz the power, 2016-12-14 20:53:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 20:56:46]

Description was changed from

==========
Add OffscreenCanvas to ImageBitmapSource union typedef

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2570613002
==========

to

==========
Add OffscreenCanvas to ImageBitmapSource union typedef

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
TBR=haraken@chromium.org

Committed: https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145
Cr-Commit-Position: refs/heads/master@{#438617}
==========

[commit-bot: I haz the power, 2016-12-14 20:56:47]

Patchset 4 (id:??) landed as
https://crrev.com/fc5d49e3a636ea62c25c512c9ac4295cf0ad5145
Cr-Commit-Position: refs/heads/master@{#438617}