Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2570573002: Convert RLZ to a buildflag header (Closed)

Created:
4 years ago by brettw
Modified:
4 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, Matt Giuca, tfarina, pkl (ping after 24h if needed), achuith+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert RLZ to a buildflag header Creates a new directory rlz/features for the gni file and the buildflag_header target. Updates callers to depend on the new target and use the new flags. Committed: https://crrev.com/8fb852d9e627bd3d1042700072e98d2884d48933 Cr-Commit-Position: refs/heads/master@{#438026}

Patch Set 1 #

Patch Set 2 : iOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -59 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_win.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/music_manager_private/music_manager_private_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/install_signer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/pepper/device_id_fetcher.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/ui_thread_search_terms_data.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 3 chunks +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 3 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/search_engines/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/search_engines/template_url_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/search_engines/ui_thread_search_terms_data.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A rlz/features/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
A rlz/features/features.gni View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (16 generated)
brettw
4 years ago (2016-12-12 18:08:51 UTC) #2
brettw
iOS
4 years ago (2016-12-12 18:20:08 UTC) #7
Roger Tawa OOO till Jul 10th
lgtm Should there be a bug id for this change?
4 years ago (2016-12-12 18:23:49 UTC) #10
brettw
On 2016/12/12 18:23:49, Roger Tawa wrote: > lgtm > > Should there be a bug ...
4 years ago (2016-12-12 18:45:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570573002/20001
4 years ago (2016-12-12 18:46:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/197317)
4 years ago (2016-12-12 22:38:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570573002/20001
4 years ago (2016-12-12 22:45:08 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/197647)
4 years ago (2016-12-13 00:22:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570573002/20001
4 years ago (2016-12-13 01:08:00 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 03:29:14 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-13 03:32:38 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8fb852d9e627bd3d1042700072e98d2884d48933
Cr-Commit-Position: refs/heads/master@{#438026}

Powered by Google App Engine
This is Rietveld 408576698