Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2570543002:
[wasm] Disable parallel compilation in predictable mode. (Closed)
Description[wasm] Disable parallel compilation in predictable mode.
R=bradnelson@chromium.org,ishell@chromium.org
BUG=
Committed: https://crrev.com/257793e3f5113e25fc6e5d92d0e0be4e9c074e74
Cr-Commit-Position: refs/heads/master@{#41652}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Use the single_threaded flag as the implicator #Messages
Total messages: 19 (10 generated)
The CQ bit was checked by titzer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
bradnelson@google.com changed reviewers: + bradnelson@google.com
lgtm
The CQ bit was unchecked by bradnelson@google.com
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2570543002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/2570543002/diff/1/src/flag-definitions.h#newc... src/flag-definitions.h:1184: DEFINE_VALUE_IMPLICATION(predictable, wasm_num_compilation_tasks, 0) It should probably be an implication of single_threaded flag.
On 2016/12/12 15:51:44, Igor Sheludko wrote: > https://codereview.chromium.org/2570543002/diff/1/src/flag-definitions.h > File src/flag-definitions.h (right): > > https://codereview.chromium.org/2570543002/diff/1/src/flag-definitions.h#newc... > src/flag-definitions.h:1184: DEFINE_VALUE_IMPLICATION(predictable, > wasm_num_compilation_tasks, 0) > It should probably be an implication of single_threaded flag. Done.
The CQ bit was checked by titzer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org, bradnelson@google.com Link to the patchset: https://codereview.chromium.org/2570543002/#ps20001 (title: "Use the single_threaded flag as the implicator")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481558069970560,
"parent_rev": "3baabedb638ac9a9b2553ea201f1f58dffdfab7f", "commit_rev":
"f607f548ff21d33c5caca628e66dd19bca773763"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Disable parallel compilation in predictable mode. R=bradnelson@chromium.org,ishell@chromium.org BUG= ========== to ========== [wasm] Disable parallel compilation in predictable mode. R=bradnelson@chromium.org,ishell@chromium.org BUG= Review-Url: https://codereview.chromium.org/2570543002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] Disable parallel compilation in predictable mode. R=bradnelson@chromium.org,ishell@chromium.org BUG= Review-Url: https://codereview.chromium.org/2570543002 ========== to ========== [wasm] Disable parallel compilation in predictable mode. R=bradnelson@chromium.org,ishell@chromium.org BUG= Committed: https://crrev.com/257793e3f5113e25fc6e5d92d0e0be4e9c074e74 Cr-Commit-Position: refs/heads/master@{#41652} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/257793e3f5113e25fc6e5d92d0e0be4e9c074e74 Cr-Commit-Position: refs/heads/master@{#41652} |
