Refactor //ios:all target in preparation of upstreaming.

Refactor //ios:all target in preparation of upstreaming.

Add temporary empty targets for each of the targets that will exists
upstream one the upstreaming process is complete.

Add "all_tests" targets for each directory that will contains test
targets, and change //ios:all to depend on them instead of depending
on the individual test targets.

Move ios_chrome_unittests target definition from ios/chrome/BUILD.gn
to ios/chrome/test/BUILD.gn.

BUG=None

Committed: https://crrev.com/e51457b8234b5cfee6be0f0d7e1a3013f7896464
Cr-Commit-Position: refs/heads/master@{#438789}

[sdefresne, 2016-12-12 13:56:51]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 13:57:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-12 13:57:46]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2016-12-12 13:57:47]

Please take a look.

[commit-bot: I haz the power, 2016-12-12 14:05:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 14:05:05]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sdefresne, 2016-12-12 15:23:24]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 15:23:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-12 15:45:57]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-12-12 17:47:24]

Ping?

[rohitrao (ping after 24h), 2016-12-12 17:52:24]

lgtm

[sdefresne, 2016-12-12 17:59:27]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-12-12 17:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 18:20:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 18:20:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sdefresne, 2016-12-12 19:40:19]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org

[sdefresne, 2016-12-12 19:40:19]

dpranke: can you take a look at testing/buildbot/OWNERS and send to CQ if LGTY?

[sdefresne, 2016-12-13 14:00:17]

dpranke: ping?

[sdefresne, 2016-12-14 11:05:42]

Description was changed from

==========
Refactor //ios:all target in preparation of upstreaming.

Add temporary empty targets for each of the targets that will exists
upstream one the upstreaming process is complete.

Add "all_tests" targets for each directory that will contains test
targets, and change //ios:all to depend on them instead of depending
on the individual test targets.

Move ios_chrome_unittests target definition from ios/chrome/BUILD.gn
to ios/chrome/test/BUILD.gn.

BUG=None
==========

to

==========
Refactor //ios:all target in preparation of upstreaming.

Add temporary empty targets for each of the targets that will exists
upstream one the upstreaming process is complete.

Add "all_tests" targets for each directory that will contains test
targets, and change //ios:all to depend on them instead of depending
on the individual test targets.

Move ios_chrome_unittests target definition from ios/chrome/BUILD.gn
to ios/chrome/test/BUILD.gn.

BUG=None
==========

[sdefresne, 2016-12-14 11:05:42]

sdefresne@chromium.org changed reviewers:
+ phajdan.jr@chromium.org
- dpranke@chromium.org

[sdefresne, 2016-12-14 11:06:17]

Paweł can you review testing/buildbot/gn_isolate_map.pyl as an OWNERS?

[sdefresne, 2016-12-14 11:34:20]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 11:34:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 12:43:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 12:43:57]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-12-15 02:55:19]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-12-15 02:55:20]

lgtm.

[Dirk Pranke, 2016-12-15 02:56:09]

Did you mean to update //testing/buildbot/OWNERS as well, or did you mean to
refer to gn_isolate_map.pyl ?

[sdefresne, 2016-12-15 09:07:02]

On 2016/12/15 02:56:09, Dirk Pranke wrote:
> Did you mean to update //testing/buildbot/OWNERS as well, or did you mean to
> refer to gn_isolate_map.pyl ?

I meant gn_isolate_map.pyl, sorry for the confusion. Thank you for the review.

[sdefresne, 2016-12-15 09:07:07]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-12-15 09:07:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2570523002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-15 09:07:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 09:11:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481792827239990,
"parent_rev": "b47ee3dfd67d79f99e36b661123d49e4f1300c86", "commit_rev":
"c97e52dd1ee38e042fe9878eb01fc3e57ae40fc7"}

[commit-bot: I haz the power, 2016-12-15 09:12:12]

Description was changed from

==========
Refactor //ios:all target in preparation of upstreaming.

Add temporary empty targets for each of the targets that will exists
upstream one the upstreaming process is complete.

Add "all_tests" targets for each directory that will contains test
targets, and change //ios:all to depend on them instead of depending
on the individual test targets.

Move ios_chrome_unittests target definition from ios/chrome/BUILD.gn
to ios/chrome/test/BUILD.gn.

BUG=None
==========

to

==========
Refactor //ios:all target in preparation of upstreaming.

Add temporary empty targets for each of the targets that will exists
upstream one the upstreaming process is complete.

Add "all_tests" targets for each directory that will contains test
targets, and change //ios:all to depend on them instead of depending
on the individual test targets.

Move ios_chrome_unittests target definition from ios/chrome/BUILD.gn
to ios/chrome/test/BUILD.gn.

BUG=None

Review-Url: https://codereview.chromium.org/2570523002
==========

[commit-bot: I haz the power, 2016-12-15 09:12:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 09:15:51]

Description was changed from

==========
Refactor //ios:all target in preparation of upstreaming.

Add temporary empty targets for each of the targets that will exists
upstream one the upstreaming process is complete.

Add "all_tests" targets for each directory that will contains test
targets, and change //ios:all to depend on them instead of depending
on the individual test targets.

Move ios_chrome_unittests target definition from ios/chrome/BUILD.gn
to ios/chrome/test/BUILD.gn.

BUG=None

Review-Url: https://codereview.chromium.org/2570523002
==========

to

==========
Refactor //ios:all target in preparation of upstreaming.

Add temporary empty targets for each of the targets that will exists
upstream one the upstreaming process is complete.

Add "all_tests" targets for each directory that will contains test
targets, and change //ios:all to depend on them instead of depending
on the individual test targets.

Move ios_chrome_unittests target definition from ios/chrome/BUILD.gn
to ios/chrome/test/BUILD.gn.

BUG=None

Committed: https://crrev.com/e51457b8234b5cfee6be0f0d7e1a3013f7896464
Cr-Commit-Position: refs/heads/master@{#438789}
==========

[commit-bot: I haz the power, 2016-12-15 09:15:52]

Patchset 3 (id:??) landed as
https://crrev.com/e51457b8234b5cfee6be0f0d7e1a3013f7896464
Cr-Commit-Position: refs/heads/master@{#438789}