Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2570503004:
Remove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html (Closed)
|
Created:
4 years ago by yhirano Modified:
4 years ago Reviewers:
tyoshino (SeeGerritForStatus) CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
The test is essentially flaky and we are unable to fix it.
BUG=518988, 143475
R=tyoshino@chromium.org
Committed: https://crrev.com/61b14954ece07545d1a828d75242da6726271f36
Cr-Commit-Position: refs/heads/master@{#438134}
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 23 (16 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== Remove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html The test is essentially flaky and we are unable to fix it. BUG=NONE R=tyoshino@chromium.org ========== to ========== Remove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html The test is essentially flaky and we are unable to fix it. BUG=518988 R=tyoshino@chromium.org ==========
Description was changed from ========== Remove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html The test is essentially flaky and we are unable to fix it. BUG=518988 R=tyoshino@chromium.org ========== to ========== Remove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html The test is essentially flaky and we are unable to fix it. BUG=518988, 143475 R=tyoshino@chromium.org ==========
The CQ bit was unchecked by yhirano@chromium.org
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -p1; error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:703 error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply Patch: third_party/WebKit/LayoutTests/TestExpectations Index: third_party/WebKit/LayoutTests/TestExpectations diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations index 5b83f0ebad02e2f67e277219e4f145051d9ed454..50ebef839f4e786b2054eda6b40b32e1aac66ef9 100644 --- a/third_party/WebKit/LayoutTests/TestExpectations +++ b/third_party/WebKit/LayoutTests/TestExpectations @@ -703,7 +703,6 @@ crbug.com/410974 virtual/threaded/fast/scroll-behavior/scroll-customization/touc crbug.com/518883 crbug.com/390452 http/tests/security/isolatedWorld/media-query-wrapper-leaks.html [ Failure Pass Timeout ] crbug.com/518883 crbug.com/390452 virtual/mojo-loading/http/tests/security/isolatedWorld/media-query-wrapper-leaks.html [ Failure Pass Timeout ] crbug.com/518987 http/tests/xmlhttprequest/navigation-abort-detaches-frame.html [ Pass Timeout ] -crbug.com/518988 [ Win7 ] http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html [ Failure Pass ] crbug.com/518989 [ Mac ] imported/csswg-test/css-writing-modes-3/writing-mode-vertical-rl-002.xht [ Failure Pass Timeout ] crbug.com/518998 media/video-poster-after-loadedmetadata.html [ Failure Pass ] @@ -1877,11 +1876,6 @@ crbug.com/669357 virtual/mojo-loading/http/tests/inspector/tracing/timeline-rece crbug.com/669357 virtual/mojo-loading/http/tests/inspector/tracing/timeline-network-received-data.html [ Failure ] crbug.com/669357 virtual/mojo-loading/http/tests/local/formdata/upload-events.html [ Failure ] -# TODO(yhirano): There is an entry for the base test, but this test is flakier -# than that. Fix this test so that we can move the entry to the base test -# section. -crbug.com/659917 virtual/mojo-loading/http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html [ Failure Pass ] - crbug.com/664873 http/tests/xmlhttprequest/small-chunks-response-text.html [ Failure Pass ] crbug.com/664873 virtual/mojo-loading/http/tests/xmlhttprequest/small-chunks-response-text.html [ Failure Pass ]
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tyoshino@chromium.org Link to the patchset: https://codereview.chromium.org/2570503004/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481630107002370,
"parent_rev": "7263e1e8c0bbaeeb8ad823d35ded227ca5da5d95", "commit_rev":
"24b331899c5195c3864f7a42c36e3ccd92bf0b0c"}
Message was sent while issue was closed.
Description was changed from ========== Remove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html The test is essentially flaky and we are unable to fix it. BUG=518988, 143475 R=tyoshino@chromium.org ========== to ========== Remove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html The test is essentially flaky and we are unable to fix it. BUG=518988, 143475 R=tyoshino@chromium.org Review-Url: https://codereview.chromium.org/2570503004 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html The test is essentially flaky and we are unable to fix it. BUG=518988, 143475 R=tyoshino@chromium.org Review-Url: https://codereview.chromium.org/2570503004 ========== to ========== Remove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html The test is essentially flaky and we are unable to fix it. BUG=518988, 143475 R=tyoshino@chromium.org Committed: https://crrev.com/61b14954ece07545d1a828d75242da6726271f36 Cr-Commit-Position: refs/heads/master@{#438134} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/61b14954ece07545d1a828d75242da6726271f36 Cr-Commit-Position: refs/heads/master@{#438134} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
