Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2570483005: Enable PlatformMediaCodecTest (Closed)

Created:
4 years ago by tguilbert
Modified:
4 years ago
Reviewers:
michaelbai
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable PlatformMediaCodecTest testCanPlayePlatformMediaCodecs was disabled due to flakiness. It seems that the test is no longer flaky and can be re-enabled (since we are no longer using WMPA, or because of some unknown changes in test reliability). NOTE: If ever the screen is off when the test runs, the test fails. BUG=620890 TEST=100x run on Nexus 5 and Nexus 7 Committed: https://crrev.com/55b7fff6cf7b3e70e03a6237e30ea60684acece9 Cr-Commit-Position: refs/heads/master@{#437984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/PlatformMediaCodecTest.java View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tguilbert
PTAL! Thanks, Thomas
4 years ago (2016-12-13 01:40:33 UTC) #6
michaelbai
lgtm
4 years ago (2016-12-13 01:50:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570483005/1
4 years ago (2016-12-13 01:54:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 02:01:37 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 02:05:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55b7fff6cf7b3e70e03a6237e30ea60684acece9
Cr-Commit-Position: refs/heads/master@{#437984}

Powered by Google App Engine
This is Rietveld 408576698