Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4438)

Unified Diff: build/toolchain/win/BUILD.gn

Issue 2570483004: Add support for link repros and use it on net_perftests. (Closed)
Patch Set: Address Scott's comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/compiler.gni ('k') | net/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/win/BUILD.gn
diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn
index 10e617b05c8aa195452feb4c16351e97aaa669a1..8efa40c26314fa1dfe14795242fe284f02863fee 100644
--- a/build/toolchain/win/BUILD.gn
+++ b/build/toolchain/win/BUILD.gn
@@ -272,6 +272,16 @@ template("msvc_toolchain") {
command = "cmd /c $python_path $tool_wrapper_path delete-file $pdbname && $command"
}
+ if (linkrepro_root_dir != "") {
+ # Create the directory that will receive the link repro for this target
+ # if needed. Note that this will create one directory per link target
+ # even if this target doesn't generate a link repro. This is necessary
+ # because the linker doesn't generate the directory specified to the
+ # /LINKREPRO flag if it doesn't exist.
+ linkrepro_dir = "$linkrepro_root_dir\\{{target_output_name}}"
+ command = "cmd /c mkdir $linkrepro_dir && $command"
+ }
+
default_output_extension = ".exe"
default_output_dir = "{{root_out_dir}}"
description = "LINK {{output}}"
« no previous file with comments | « build/config/compiler/compiler.gni ('k') | net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698