DCHECK in BudgetService getCost and reserve if an invalid type is supplied.

DCHECK in BudgetService getCost and reserve if an invalid type is supplied.

If an incorrect type is provided to the call, the generated IDL code will
reject with a TypeError. This patch removes code in the service
implementation which was checking whether the type was invalid and returning
a NotSupportedError. The only way this code could be hit would be if there
was a programming error, so it should be a DCHECK.

BUG=672113
Committed: https://crrev.com/c774d5e31f3d0333dfdf921c0befcc89d1bd1259
Cr-Commit-Position: refs/heads/master@{#437897}

[harkness, 2016-12-12 14:01:27]

harkness@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2016-12-12 14:22:00]

lgtm

This is already covered by two layout tests :)

https://codereview.chromium.org/2570463003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/budget/BudgetService.cpp (right):

https://codereview.chromium.org/2570463003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/budget/BudgetService.cpp:68: DCHECK(type !=
mojom::blink::BudgetOperationType::INVALID_OPERATION);
Please check whether the following works instead:

  DCHECK_NE(type, mojom::blink::BudgetOperationType::INVALID_OPERATION);

(Which produces slightly nicer error messages.)

[harkness, 2016-12-12 15:00:43]

https://codereview.chromium.org/2570463003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/budget/BudgetService.cpp (right):

https://codereview.chromium.org/2570463003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/budget/BudgetService.cpp:68: DCHECK(type !=
mojom::blink::BudgetOperationType::INVALID_OPERATION);
On 2016/12/12 14:22:00, Peter Beverloo wrote:
> Please check whether the following works instead:
> 
>   DCHECK_NE(type, mojom::blink::BudgetOperationType::INVALID_OPERATION);
> 
> (Which produces slightly nicer error messages.)

I didn't realize the macro was flexible enough to do the comparison, very cool.

Done.

[harkness, 2016-12-12 15:00:52]

The CQ bit was checked by harkness@chromium.org

[harkness, 2016-12-12 15:00:53]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2570463003/#ps20001
(title: "Change != to DCHECK_NE")

[commit-bot: I haz the power, 2016-12-12 15:01:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 16:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 16:17:56]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[harkness, 2016-12-12 16:53:53]

The CQ bit was checked by harkness@chromium.org

[commit-bot: I haz the power, 2016-12-12 16:54:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 17:51:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481561633224270,
"parent_rev": "f7430cf5413cb28aa45599823939811221db2964", "commit_rev":
"b9954368ca6f9e60758a07bc52aac253eda1a38c"}

[commit-bot: I haz the power, 2016-12-12 17:51:29]

Description was changed from

==========
DCHECK in BudgetService getCost and reserve if an invalid type is supplied.

If an incorrect type is provided to the call, the generated IDL code will
reject with a TypeError. This patch removes code in the service
implementation which was checking whether the type was invalid and returning
a NotSupportedError. The only way this code could be hit would be if there
was a programming error, so it should be a DCHECK.

BUG=672113
==========

to

==========
DCHECK in BudgetService getCost and reserve if an invalid type is supplied.

If an incorrect type is provided to the call, the generated IDL code will
reject with a TypeError. This patch removes code in the service
implementation which was checking whether the type was invalid and returning
a NotSupportedError. The only way this code could be hit would be if there
was a programming error, so it should be a DCHECK.

BUG=672113

Review-Url: https://codereview.chromium.org/2570463003
==========

[commit-bot: I haz the power, 2016-12-12 17:51:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 18:21:30]

Description was changed from

==========
DCHECK in BudgetService getCost and reserve if an invalid type is supplied.

If an incorrect type is provided to the call, the generated IDL code will
reject with a TypeError. This patch removes code in the service
implementation which was checking whether the type was invalid and returning
a NotSupportedError. The only way this code could be hit would be if there
was a programming error, so it should be a DCHECK.

BUG=672113

Review-Url: https://codereview.chromium.org/2570463003
==========

to

==========
DCHECK in BudgetService getCost and reserve if an invalid type is supplied.

If an incorrect type is provided to the call, the generated IDL code will
reject with a TypeError. This patch removes code in the service
implementation which was checking whether the type was invalid and returning
a NotSupportedError. The only way this code could be hit would be if there
was a programming error, so it should be a DCHECK.

BUG=672113

Committed: https://crrev.com/c774d5e31f3d0333dfdf921c0befcc89d1bd1259
Cr-Commit-Position: refs/heads/master@{#437897}
==========

[commit-bot: I haz the power, 2016-12-12 18:21:31]

Patchset 2 (id:??) landed as
https://crrev.com/c774d5e31f3d0333dfdf921c0befcc89d1bd1259
Cr-Commit-Position: refs/heads/master@{#437897}