Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2570463002: Moved -webkit-print-color-adjust property to be generated. (Closed)

Created:
4 years ago by napper
Modified:
4 years ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dshwang, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved -webkit-print-color-adjust property to be generated. Moved -webkit-print-color-adjust property to be generated, so now the getter/setter methods for print-color-adjust are generated. This means that getPrintColorAdjust() has been renamed to printColorAdjust(). Also renamed PrintColorAdjust enum to EPrintColorAdjust for consistency with other generated enums. BUG=628043 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/52fa8397a15c91bf315303370bbffcf05f807f8d Cr-Commit-Position: refs/heads/master@{#438723}

Patch Set 1 #

Patch Set 2 : Fixed additional usages of getPrintColorAdjust(). #

Patch Set 3 : Fixed additional usages of getPrintColorAdjust(). #

Patch Set 4 : Renamed PrintColorAdjust to EPrintColorAdjust. #

Patch Set 5 : Removed debugging statements from make_style_builder.py. #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -29 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 5 6 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 5 6 4 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 40 (32 generated)
napper
4 years ago (2016-12-14 02:15:05 UTC) #23
sashab
Change your patch description so the first line of the description is the title followed ...
4 years ago (2016-12-14 02:29:51 UTC) #24
napper
On 2016/12/14 at 02:29:51, sashab wrote: > Change your patch description so the first line ...
4 years ago (2016-12-14 05:21:46 UTC) #26
napper
4 years ago (2016-12-14 05:21:51 UTC) #27
sashab
lgtm
4 years ago (2016-12-15 03:04:25 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570463002/120001
4 years ago (2016-12-15 03:06:08 UTC) #35
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years ago (2016-12-15 03:12:25 UTC) #38
commit-bot: I haz the power
4 years ago (2016-12-15 03:16:29 UTC) #40
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/52fa8397a15c91bf315303370bbffcf05f807f8d
Cr-Commit-Position: refs/heads/master@{#438723}

Powered by Google App Engine
This is Rietveld 408576698