Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2570433004:
Made nextElementSibling and previousElementSibling nullable (Closed)
DescriptionMade nextElementSibling and previousElementSibling nullable
No generated code is changed
spec: https://dom.spec.whatwg.org/#interface-nondocumenttypechildnode
BUG=662005
Committed: https://crrev.com/1dc57917e3d0d9a4a15f78bebeae831b221d80d1
Cr-Commit-Position: refs/heads/master@{#438105}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== Made nextElementSibling and previousElementSibling nullable spec: https://dom.spec.whatwg.org/#interface-nondocumenttypechildnode BUG=662005 ========== to ========== Made nextElementSibling and previousElementSibling nullable No generated code is changed spec: https://dom.spec.whatwg.org/#interface-nondocumenttypechildnode BUG=662005 ==========
foolip@chromium.org changed reviewers: + foolip@chromium.org
lgtm
The CQ bit was checked by foolip@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by lunalu@chromium.org
The CQ bit was checked by lunalu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by lunalu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481618508704070, "parent_rev":
"6959c72f403723dca09e36ede3f8d7ddd941b695", "commit_rev":
"4eae2c49404949fc95d710988d2a3f8ca5e199c1"}
Message was sent while issue was closed.
Description was changed from ========== Made nextElementSibling and previousElementSibling nullable No generated code is changed spec: https://dom.spec.whatwg.org/#interface-nondocumenttypechildnode BUG=662005 ========== to ========== Made nextElementSibling and previousElementSibling nullable No generated code is changed spec: https://dom.spec.whatwg.org/#interface-nondocumenttypechildnode BUG=662005 Review-Url: https://codereview.chromium.org/2570433004 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Made nextElementSibling and previousElementSibling nullable No generated code is changed spec: https://dom.spec.whatwg.org/#interface-nondocumenttypechildnode BUG=662005 Review-Url: https://codereview.chromium.org/2570433004 ========== to ========== Made nextElementSibling and previousElementSibling nullable No generated code is changed spec: https://dom.spec.whatwg.org/#interface-nondocumenttypechildnode BUG=662005 Committed: https://crrev.com/1dc57917e3d0d9a4a15f78bebeae831b221d80d1 Cr-Commit-Position: refs/heads/master@{#438105} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1dc57917e3d0d9a4a15f78bebeae831b221d80d1 Cr-Commit-Position: refs/heads/master@{#438105} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
