Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2570433002: client/isolate: correctly propagate context.Context (Closed)

Created:
4 years ago by djd-OOO-Apr2017
Modified:
4 years ago
Reviewers:
mcgreevy
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

client/isolate: correctly propagate context.Context This was overlooked in luci/luci-go@8336655 since the unti test fake doesn't use the context at all. BUG=598990 R=mcgreevy@chromium.org Review-Url: https://codereview.chromium.org/2570433002 Committed: https://github.com/luci/luci-go/commit/a5a69040846b468ebb09aef5cc458df85575b499

Patch Set 1 #

Patch Set 2 : Add test that would have caught issue #

Patch Set 3 : diff from other CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M client/cmd/isolate/checker.go View 1 chunk +1 line, -0 lines 0 comments Download
M client/cmd/isolate/checker_test.go View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
djd-OOO-Apr2017
4 years ago (2016-12-11 23:59:57 UTC) #1
mcgreevy
lgtm
4 years ago (2016-12-12 00:38:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570433002/40001
4 years ago (2016-12-12 00:50:53 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-12 00:56:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/a5a69040846b468ebb09aef5cc458df85575b499

Powered by Google App Engine
This is Rietveld 408576698