Remove paintOffsetTranslation for fixed-position elements.

Remove paintOffsetTranslation for fixed-position elements.

Thus only transformed elements now paint with transform. The concept
of painting fixed-position elements with transform was introduced in
https://codereview.chromium.org/1110653003, to help with paint invalidation
of SPv1. However we ended up invalidating whole subtrees on scroll in v1,
so this is not necessary.

Also added invalidation of paint properties when changing compositing mode,
since this can affect whether paintsWithTransform changes its behavior.

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/346b1c326cb8c8c2978de61294338d3575708a86
Cr-Commit-Position: refs/heads/master@{#440906}

[chrishtr, 2016-12-14 20:23:51]

Description was changed from

==========
none

BUG=
==========

to

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-12-14 22:16:52]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:17:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 23:34:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 23:34:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-12-15 18:47:11]

Description was changed from

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
none

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-15 22:26:12]

Description was changed from

==========
none

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove paintOffsetTranslation for fixed-position elements.

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-15 22:29:07]

Description was changed from

==========
Remove paintOffsetTranslation for fixed-position elements.

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove paintOffsetTranslation for fixed-position elements.

Thus only transformed elements now paint with transform. The concept
of painting fixed-position elements with transform was introduced in
https://codereview.chromium.org/1110653003, to help with paint invalidation
of SPv1. However we ended up invalidating whole subtrees on scroll in v1,
so this is not necessary.

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-15 22:30:36]

chrishtr@chromium.org changed reviewers:
+ trchen@chromium.org, wangxianzhu@chromium.org

[chrishtr, 2016-12-15 22:30:52]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 22:32:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-15 22:37:11]

lgtm

https://codereview.chromium.org/2570423003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right):

https://codereview.chromium.org/2570423003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:303: if (hadLayer
!= hasLayer()) {
Nit:
if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() &&
    hadLayer != hasLayer()) {
 // hasLayer status will affect whether to create localBorderBoxProperties.
 setNeedsPaintPropertyUpdate();
}

[commit-bot: I haz the power, 2016-12-16 00:04:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 00:04:29]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-12-27 20:03:54]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 20:04:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 20:35:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 20:35:58]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-12-27 20:53:02]

https://codereview.chromium.org/2570423003/diff/120001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2570423003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:221:
Bug(none) compositing/iframes/iframe-resize.html [ Failure ]
The two added tests here fail because scrolling is not yet implemented for
SPv2.

[chrishtr, 2016-12-27 20:53:07]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-27 20:53:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2570423003/#ps120001
(title: "none")

[commit-bot: I haz the power, 2016-12-27 20:53:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 22:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 22:33:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2016-12-28 01:18:41]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 01:18:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 01:50:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 01:50:55]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-12-28 01:57:09]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 01:57:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 03:13:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 03:13:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-12-28 18:34:50]

Description was changed from

==========
Remove paintOffsetTranslation for fixed-position elements.

Thus only transformed elements now paint with transform. The concept
of painting fixed-position elements with transform was introduced in
https://codereview.chromium.org/1110653003, to help with paint invalidation
of SPv1. However we ended up invalidating whole subtrees on scroll in v1,
so this is not necessary.

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove paintOffsetTranslation for fixed-position elements.

Thus only transformed elements now paint with transform. The concept
of painting fixed-position elements with transform was introduced in
https://codereview.chromium.org/1110653003, to help with paint invalidation
of SPv1. However we ended up invalidating whole subtrees on scroll in v1,
so this is not necessary.

Also added invalidation of paint properties when changing compositing mode,
since this can affect whether paintsWithTransform changes its behavior.

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-28 18:39:17]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 18:39:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 21:05:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 21:05:13]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-12-28 21:52:22]

Please take a new look. See comment below.

https://codereview.chromium.org/2570423003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):

https://codereview.chromium.org/2570423003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:430: } else if
(!collectPaintFragmentsForPaginatedFixedPosition(
This code is new.

[Xianzhu, 2016-12-28 22:19:46]

lgtm

https://codereview.chromium.org/2570423003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):

https://codereview.chromium.org/2570423003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:607: LOG(ERROR) <<
"wtf";
Remove.

[chrishtr, 2016-12-28 22:27:39]

https://codereview.chromium.org/2570423003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):

https://codereview.chromium.org/2570423003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:607: LOG(ERROR) <<
"wtf";
On 2016/12/28 at 22:19:46, Xianzhu wrote:
> Remove.

Oops, sorry. Removed.

[chrishtr, 2016-12-28 22:28:15]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-28 22:28:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2570423003/#ps220001
(title: "none")

[commit-bot: I haz the power, 2016-12-28 22:28:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 23:47:38]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1482964095719310,
"parent_rev": "6cc47f4dae9bafda4f25873e76bcd447c0ccc19c", "commit_rev":
"af1e86202b04a491483ce787ac496ad2c63e7bb2"}

[commit-bot: I haz the power, 2016-12-28 23:48:11]

Description was changed from

==========
Remove paintOffsetTranslation for fixed-position elements.

Thus only transformed elements now paint with transform. The concept
of painting fixed-position elements with transform was introduced in
https://codereview.chromium.org/1110653003, to help with paint invalidation
of SPv1. However we ended up invalidating whole subtrees on scroll in v1,
so this is not necessary.

Also added invalidation of paint properties when changing compositing mode,
since this can affect whether paintsWithTransform changes its behavior.

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove paintOffsetTranslation for fixed-position elements.

Thus only transformed elements now paint with transform. The concept
of painting fixed-position elements with transform was introduced in
https://codereview.chromium.org/1110653003, to help with paint invalidation
of SPv1. However we ended up invalidating whole subtrees on scroll in v1,
so this is not necessary.

Also added invalidation of paint properties when changing compositing mode,
since this can affect whether paintsWithTransform changes its behavior.

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2570423003
==========

[commit-bot: I haz the power, 2016-12-28 23:48:12]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2017-01-02 15:50:47]

Description was changed from

==========
Remove paintOffsetTranslation for fixed-position elements.

Thus only transformed elements now paint with transform. The concept
of painting fixed-position elements with transform was introduced in
https://codereview.chromium.org/1110653003, to help with paint invalidation
of SPv1. However we ended up invalidating whole subtrees on scroll in v1,
so this is not necessary.

Also added invalidation of paint properties when changing compositing mode,
since this can affect whether paintsWithTransform changes its behavior.

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2570423003
==========

to

==========
Remove paintOffsetTranslation for fixed-position elements.

Thus only transformed elements now paint with transform. The concept
of painting fixed-position elements with transform was introduced in
https://codereview.chromium.org/1110653003, to help with paint invalidation
of SPv1. However we ended up invalidating whole subtrees on scroll in v1,
so this is not necessary.

Also added invalidation of paint properties when changing compositing mode,
since this can affect whether paintsWithTransform changes its behavior.

BUG=674623
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/346b1c326cb8c8c2978de61294338d3575708a86
Cr-Commit-Position: refs/heads/master@{#440906}
==========

[commit-bot: I haz the power, 2017-01-02 15:50:48]

Patchset 12 (id:??) landed as
https://crrev.com/346b1c326cb8c8c2978de61294338d3575708a86
Cr-Commit-Position: refs/heads/master@{#440906}