operator* and and operator-> on iterators should be const

operator* and and operator-> on iterators should be const

Required by the standard, and, apparently, MSVC2017.

Also remove redundant `inline`s (methods defined within a class body
are implicit inilne already), and use the iterator typedefs more.

BUG=none

Committed: https://crrev.com/be4f04515cf473226b9c30f4dd722fa3379dc17f
Cr-Commit-Position: refs/heads/master@{#438557}

[Nico, 2016-12-14 16:24:34]

thakis@chromium.org changed reviewers:
+ jsbell@chromium.org

[Nico, 2016-12-14 16:24:41]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 16:24:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 16:45:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:45:20]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-12-14 16:52:44]

lgtm

[Nico, 2016-12-14 17:19:32]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:20:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 18:51:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481735972334170, "parent_rev":
"7c914b416bcb62e7650095aacdeaef062a732ed9", "commit_rev":
"10f106c8c3718f0004520cea3855e0ffca6e0e5d"}

[commit-bot: I haz the power, 2016-12-14 18:52:20]

Description was changed from

==========
operator* and and operator-> on iterators should be const

Required by the standard, and, apparently, MSVC2017.

Also remove redundant `inline`s (methods defined within a class body
are implicit inilne already), and use the iterator typedefs more.

BUG=none
==========

to

==========
operator* and and operator-> on iterators should be const

Required by the standard, and, apparently, MSVC2017.

Also remove redundant `inline`s (methods defined within a class body
are implicit inilne already), and use the iterator typedefs more.

BUG=none

Review-Url: https://codereview.chromium.org/2570343002
==========

[commit-bot: I haz the power, 2016-12-14 18:52:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 18:54:17]

Description was changed from

==========
operator* and and operator-> on iterators should be const

Required by the standard, and, apparently, MSVC2017.

Also remove redundant `inline`s (methods defined within a class body
are implicit inilne already), and use the iterator typedefs more.

BUG=none

Review-Url: https://codereview.chromium.org/2570343002
==========

to

==========
operator* and and operator-> on iterators should be const

Required by the standard, and, apparently, MSVC2017.

Also remove redundant `inline`s (methods defined within a class body
are implicit inilne already), and use the iterator typedefs more.

BUG=none

Committed: https://crrev.com/be4f04515cf473226b9c30f4dd722fa3379dc17f
Cr-Commit-Position: refs/heads/master@{#438557}
==========

[commit-bot: I haz the power, 2016-12-14 18:54:18]

Patchset 1 (id:??) landed as
https://crrev.com/be4f04515cf473226b9c30f4dd722fa3379dc17f
Cr-Commit-Position: refs/heads/master@{#438557}

[sof, 2016-12-15 12:46:17]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2016-12-15 12:46:17]

Thanks for the fix!

This one's been a problem for me for a while with non-MSVC toolchains (
https://codereview.chromium.org/2472213003/#msg77 .)