Do not implement EventTarget on SVGElementInstance

Do not implement EventTarget on SVGElementInstance

Do not implement EventTarget on SVGElementInstance, since SVGElementInstance is scheduled for removal and event handling should be handled in the shadow tree. So instead set the shadow tree elements as event target.

BUG=313438
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175307

[pdr., 2014-04-30 21:08:54]

I like where this is heading!

Could you add a test or two of what happens if you click a rect that's in the
use shadow tree? My understanding of the spec is that we should retarget this
event as if it came from the <use> element itself.

[rwlbuis, 2014-05-28 22:28:32]

On 2014/04/30 21:08:54, pdr wrote:
> I like where this is heading!
> 
> Could you add a test or two of what happens if you click a rect that's in the
> use shadow tree? My understanding of the spec is that we should retarget this
> event as if it came from the <use> element itself.

I got a bit sidetracked but ready to revisit this now. Philip could you have a
look what is still needed for this change to land?

[pdr., 2014-05-28 23:41:14]

On 2014/05/28 22:28:32, rwlbuis wrote:
> On 2014/04/30 21:08:54, pdr wrote:
> > I like where this is heading!
> > 
> > Could you add a test or two of what happens if you click a rect that's in
the
> > use shadow tree? My understanding of the spec is that we should retarget
this
> > event as if it came from the <use> element itself.
> 
> I got a bit sidetracked but ready to revisit this now. Philip could you have a
> look what is still needed for this change to land?

Could you rebase this and add the test?

[rwlbuis, 2014-05-29 15:20:45]

On 2014/05/28 23:41:14, pdr wrote:
> On 2014/05/28 22:28:32, rwlbuis wrote:
> > On 2014/04/30 21:08:54, pdr wrote:
> > > I like where this is heading!
> > > 
> > > Could you add a test or two of what happens if you click a rect that's in
> the
> > > use shadow tree? My understanding of the spec is that we should retarget
> this
> > > event as if it came from the <use> element itself.
> > 
> > I got a bit sidetracked but ready to revisit this now. Philip could you have
a
> > look what is still needed for this change to land?
> 
> Could you rebase this and add the test?

Oops, seems like the test got lost in translation, will add.

[pdr., 2014-06-02 14:09:06]

LGTM with a question about SVG logic in EventPath.cpp

https://codereview.chromium.org/257033002/diff/280001/Source/core/events/Even...
File Source/core/events/EventPath.cpp (right):

https://codereview.chromium.org/257033002/diff/280001/Source/core/events/Even...
Source/core/events/EventPath.cpp:61: if
(!usesDeprecatedSVGUseTreeEventRules(referenceNode))
I thought we could remove all svg-specific logic here, though I may be missing
something.

[rwlbuis, 2014-06-02 14:48:01]

On 2014/06/02 14:09:06, pdr wrote:
> LGTM with a question about SVG logic in EventPath.cpp

Thanks! And you are up early :)

>
https://codereview.chromium.org/257033002/diff/280001/Source/core/events/Even...
> File Source/core/events/EventPath.cpp (right):
> 
>
https://codereview.chromium.org/257033002/diff/280001/Source/core/events/Even...
> Source/core/events/EventPath.cpp:61: if
> (!usesDeprecatedSVGUseTreeEventRules(referenceNode))
> I thought we could remove all svg-specific logic here, though I may be missing
> something.

I think so too but I wanted to be careful. I can try a new patch without it, I
need to rebase anyway. It is really hard to keep a patch current
when it has a change to TestExpectations :]

[rwlbuis, 2014-06-02 16:36:53]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-06-02 16:37:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob.buis@samsung.com/257033002/300001

[commit-bot: I haz the power, 2014-06-02 17:44:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6690)

[commit-bot: I haz the power, 2014-06-02 17:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-02 17:47:09]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6703)

[rwlbuis, 2014-06-02 18:00:15]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-06-02 18:00:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob.buis@samsung.com/257033002/300001

[commit-bot: I haz the power, 2014-06-02 18:15:36]

Change committed as 175307