Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: LayoutTests/svg/custom/resources/use-instanceRoot-event-bubbling.js

Issue 257033002: Do not implement EventTarget on SVGElementInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Try to fix TestExpectations Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/svg/custom/resources/use-instanceRoot-event-bubbling.js
diff --git a/LayoutTests/svg/custom/resources/use-instanceRoot-event-bubbling.js b/LayoutTests/svg/custom/resources/use-instanceRoot-event-bubbling.js
index 5c183290e67f684e2eb976aa9905c741b508e43f..d14905a5bc7a4a260cdde9a25f855ac58096e2b8 100644
--- a/LayoutTests/svg/custom/resources/use-instanceRoot-event-bubbling.js
+++ b/LayoutTests/svg/custom/resources/use-instanceRoot-event-bubbling.js
@@ -41,7 +41,7 @@ function finishTest()
{
successfullyParsed = true;
- use.instanceRoot.correspondingElement.setAttribute("fill", "green");
+ rectContainer.setAttribute("fill", "green");
shouldBeTrue("successfullyParsed");
debug('<br /><span class="pass">TEST COMPLETE</span>');
@@ -56,22 +56,22 @@ function nextTest()
switch (counter) {
case 1:
rect.onclick = function(evt) { eventHandler(evt, 1); };
- expected[0] = "[EventHandler 1] type: click phase: AT_TARGET target: [object SVGElementInstance] (id: rect) currentTarget: [object SVGElementInstance] (id: rect)";
+ expected[0] = "[EventHandler 1] type: click phase: AT_TARGET target: [object SVGUseElement] (id: use) currentTarget: [object SVGUseElement] (id: use)";
testListeners();
break;
case 2:
rectContainer.addEventListener("click", function(evt) { eventHandler(evt, 2) }, false);
- expected[1] = "[EventHandler 2] type: click phase: BUBBLING target: [object SVGElementInstance] (id: rect) currentTarget: [object SVGElementInstance] (id: rectParent)";
+ expected[1] = "[EventHandler 2] type: click phase: AT_TARGET target: [object SVGUseElement] (id: use) currentTarget: [object SVGUseElement] (id: use)";
testListeners();
break;
case 3:
use.setAttribute("onclick", "eventHandler(evt, 3)");
- expected[2] = "[EventHandler 3] type: click phase: BUBBLING target: [object SVGElementInstance] (id: rect) currentTarget: [object SVGUseElement] (id: use)";
+ expected[2] = "[EventHandler 3] type: click phase: AT_TARGET target: [object SVGUseElement] (id: use) currentTarget: [object SVGUseElement] (id: use)";
testListeners();
break;
case 4:
useContainer.onclick = function(evt) { eventHandler(evt, 4) };
- expected[3] = "[EventHandler 4] type: click phase: BUBBLING target: [object SVGElementInstance] (id: rect) currentTarget: [object SVGGElement] (id: useParent)";
+ expected[3] = "[EventHandler 4] type: click phase: BUBBLING target: [object SVGUseElement] (id: use) currentTarget: [object SVGGElement] (id: useParent)";
testListeners();
break;
}

Powered by Google App Engine
This is Rietveld 408576698