Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2570293003: Revert of Set overflow: auto in StyleResolver::styleForDocument. (Closed)

Created:
4 years ago by paulmeyer
Modified:
4 years ago
Reviewers:
bokan, skobes, szager1
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set overflow: auto in StyleResolver::styleForDocument. (patchset #1 id:1 of https://codereview.chromium.org/2571893003/ ) Reason for revert: This breaks compiles on Android Cast bot: https://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/58645 Original issue's description: > Set overflow: auto in StyleResolver::styleForDocument. > > Without this, the call to setStyle in Document::updateStyle would temporarily > mark the LayoutView as overflow: visible. With root layer scrolling this causes > PaintLayerScrollableArea to remove the scrollbars. > > This change has no effect on the document's final overflow style, which comes > from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS). > > BUG=672335 > > Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0 > Cr-Commit-Position: refs/heads/master@{#438533} TBR=bokan@chromium.org,szager@chromium.org,skobes@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672335 Committed: https://crrev.com/503a8299269f0cf0e838ce922228646b7bde6d21 Cr-Commit-Position: refs/heads/master@{#438537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimTest.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimTest.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
paulmeyer
Created Revert of Set overflow: auto in StyleResolver::styleForDocument.
4 years ago (2016-12-14 17:12:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570293003/1
4 years ago (2016-12-14 17:12:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 17:14:12 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-14 17:16:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/503a8299269f0cf0e838ce922228646b7bde6d21
Cr-Commit-Position: refs/heads/master@{#438537}

Powered by Google App Engine
This is Rietveld 408576698