Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2570293002: Make LayoutSVGViewportContainer <-> SVGSVGElement association obvious (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make LayoutSVGViewportContainer -> SVGSVGElement association obvious This LayoutObject type is only used for non-outermost SVGSVGElements, so no need to do runtime checks of the type. Committed: https://crrev.com/5dffc7467bb43867a051615beca722e46060b34d Cr-Commit-Position: refs/heads/master@{#438532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.cpp View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
fs
4 years ago (2016-12-14 14:27:44 UTC) #5
Stephen Chennney
lgtm
4 years ago (2016-12-14 15:35:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570293002/1
4 years ago (2016-12-14 15:35:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 16:53:46 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5dffc7467bb43867a051615beca722e46060b34d Cr-Commit-Position: refs/heads/master@{#438532}
4 years ago (2016-12-14 16:55:10 UTC) #16
pdr.
4 years ago (2016-12-14 21:55:08 UTC) #17
Message was sent while issue was closed.
SGTM LGTM 2

Powered by Google App Engine
This is Rietveld 408576698