[SPv2] Associate effect property nodes for SVG paint chunks

third_party/WebKit/Source/core/layout/LayoutObject.h

Index: third_party/WebKit/Source/core/layout/LayoutObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h
index b2d6e637b7943caac748a51f17eb13723413751e..8ad82ec76a342fc243a29d9ea3da1df7b9c71deb 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h
@@ -649,7 +649,11 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
     return !isSVG() || (isSVGContainer() && !isSVGHiddenContainer()) ||
            isSVGShape() || isSVGImage() || isSVGText();
   }
-  virtual bool hasNonIsolatedBlendingDescendants() const { return false; }
+  virtual bool hasNonIsolatedBlendingDescendants() const {

[chrishtr, 2016/12/21 21:39:24]

Why do you need to make the changes to hasNonIsolatedBlendingDescendants? Your
patch no longer calls
that method.

[trchen, 2016/12/21 22:36:41]

Yea... This really belongs to a split out. Done.

+    // SVG only. For non-SVG objects, query PaintLayer instead.
+    NOTREACHED();

[pdr., 2016/12/21 19:12:52]

What about DCHECK(isSVG()); and remove the other overrides?

[trchen, 2016/12/21 22:36:41]

That's genius! I'll do that instead (in a split out of course).

+    return false;
+  }
   enum DescendantIsolationState {
     DescendantIsolationRequired,
     DescendantIsolationNeedsUpdate,