[SPv2] Associate effect property nodes for SVG paint chunks

third_party/WebKit/Source/core/layout/LayoutObject.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 631 matching lines @@
   // (see above). Unfortunately we don't have such a class yet, because it's not
   // possible for all layoutObjects to inherit from LayoutSVGObject ->
   // LayoutObject (some need LayoutBlock inheritance for instance)
   virtual void setNeedsTransformUpdate() {}
   virtual void setNeedsBoundariesUpdate();
 
   bool isBlendingAllowed() const {
     return !isSVG() || (isSVGContainer() && !isSVGHiddenContainer()) ||
            isSVGShape() || isSVGImage() || isSVGText();
   }
-  virtual bool hasNonIsolatedBlendingDescendants() const { return false; }
+  virtual bool hasNonIsolatedBlendingDescendants() const {

[chrishtr, 2016/12/21 21:39:24]

Why do you need to make the changes to hasNonIsolatedBlendingDescendants? Your
patch no longer calls
that method.

[trchen, 2016/12/21 22:36:41]

Yea... This really belongs to a split out. Done.

+    // SVG only. For non-SVG objects, query PaintLayer instead.
+    NOTREACHED();

[pdr., 2016/12/21 19:12:52]

What about DCHECK(isSVG()); and remove the other overrides?

[trchen, 2016/12/21 22:36:41]

That's genius! I'll do that instead (in a split out of course).

+    return false;
+  }
   enum DescendantIsolationState {
     DescendantIsolationRequired,
     DescendantIsolationNeedsUpdate,
   };
   virtual void descendantIsolationRequirementsChanged(
       DescendantIsolationState) {}
 
   // Per SVG 1.1 objectBoundingBox ignores clipping, masking, filter effects,
   // opacity and stroke-width.
   // This is used for all computation of objectBoundingBox relative units and by
@@ skipping 2005 matching lines @@
 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
 // We don't make object2 an optional parameter so that showLayoutTree
 // can be called from gdb easily.
 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
                                 const blink::LayoutObject* object2);
 
 #endif
 
 #endif  // LayoutObject_h