Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2570203002: clear-data-reduction-proxy-data-savings flag should clear savings on Android (Closed)

Created:
4 years ago by megjablon
Modified:
4 years ago
Reviewers:
sclittle
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clear-data-reduction-proxy-data-savings flag should clear savings on Android The flag currently doesn't clear savings on Android because of an early return. Since the map of pref lists isn't populated for pref writing writing with zero delay, ClearDataSavingStatistics needs to also clear the prefs using the pref service. BUG=673932 Committed: https://crrev.com/1d0b50bd55b962139d7a46182f991ad1f3b775ed Cr-Commit-Position: refs/heads/master@{#438576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc View 3 chunks +26 lines, -27 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
megjablon
PTAL, thanks!
4 years ago (2016-12-14 01:11:11 UTC) #6
sclittle
lgtm
4 years ago (2016-12-14 18:56:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570203002/1
4 years ago (2016-12-14 19:03:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 19:15:14 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 19:16:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d0b50bd55b962139d7a46182f991ad1f3b775ed
Cr-Commit-Position: refs/heads/master@{#438576}

Powered by Google App Engine
This is Rietveld 408576698