Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 2570193003: Make boilerplate.py add newline to end of generated files. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make boilerplate.py add newline to end of generated files. Make boilerplate.py add newline to the end of generated .cc and .mm files. Committed: https://crrev.com/3d3150b306242e8253fcf1a2db5cf2ddb2ab7fa8 Cr-Commit-Position: refs/heads/master@{#438580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M tools/boilerplate.py View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Bence
Robert: PTAL. Thank you.
4 years ago (2016-12-14 17:28:26 UTC) #2
Robert Sesek
LGTM
4 years ago (2016-12-14 18:43:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570193003/1
4 years ago (2016-12-14 18:48:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 19:19:30 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-14 19:22:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d3150b306242e8253fcf1a2db5cf2ddb2ab7fa8
Cr-Commit-Position: refs/heads/master@{#438580}

Powered by Google App Engine
This is Rietveld 408576698