Rename OnError to OnErrorAdapter and OnSuccess to OnSucessAdapter.

Rename OnError to OnErrorAdapter and OnSuccess to OnSucessAdapter.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |OnError| type and
an |onError| virtual method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |OnError| being the name of both the type and the method (with both
living in the same namespace). Similar situation happens for onSuccess /
OnSuccess names.

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480
Committed: https://crrev.com/18c69c35b756dca9096cf2fc0ab69d4b6d7ddba5
Cr-Commit-Position: refs/heads/master@{#438579}

[Łukasz Anforowicz, 2016-12-13 23:40:54]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 23:41:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-12-14 00:58:46]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org, esprehn@chromium.org

[Łukasz Anforowicz, 2016-12-14 00:58:46]

dcheng@ + esprehn@, can you PTAL?


I like appending Adapter suffix to the typenames, because:

1. dcheng@ says that appending Handler suffix to the method names seems weird

2. Appending Adapter suffix only requires tweaking a single header file

3. Adapter suffix is used in the other types in the modified header file and
seems to semantically match.


WDYT?

[Łukasz Anforowicz, 2016-12-14 00:59:36]

Description was changed from

==========
Rename OnError to OnErrorAdapter and OnSuccess to OnSucessAdapter.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |OnError| type and
an |onError| virtual method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |OnError| being the name of both the type and the method (with both
living in the same namespace). Similar situation happens for onSuccess /
OnSuccess names.

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
==========

to

==========
Rename OnError to OnErrorAdapter and OnSuccess to OnSucessAdapter.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |OnError| type and
an |onError| virtual method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |OnError| being the name of both the type and the method (with both
living in the same namespace). Similar situation happens for onSuccess /
OnSuccess names.

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480
==========

[haraken, 2016-12-14 01:19:58]

LGTM

[dcheng, 2016-12-14 01:29:44]

LGTM as well, thanks!

[commit-bot: I haz the power, 2016-12-14 02:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 02:10:16]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-12-14 17:39:17]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:40:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 19:18:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481737157875260, "parent_rev":
"5c0b1af0ce03ff9264b800079aa2690a268c7b2d", "commit_rev":
"6119e2263fe7c46d57be889442e3a93af39be915"}

[commit-bot: I haz the power, 2016-12-14 19:18:27]

Description was changed from

==========
Rename OnError to OnErrorAdapter and OnSuccess to OnSucessAdapter.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |OnError| type and
an |onError| virtual method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |OnError| being the name of both the type and the method (with both
living in the same namespace). Similar situation happens for onSuccess /
OnSuccess names.

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480
==========

to

==========
Rename OnError to OnErrorAdapter and OnSuccess to OnSucessAdapter.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |OnError| type and
an |onError| virtual method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |OnError| being the name of both the type and the method (with both
living in the same namespace). Similar situation happens for onSuccess /
OnSuccess names.

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480

Review-Url: https://codereview.chromium.org/2570193002
==========

[commit-bot: I haz the power, 2016-12-14 19:18:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 19:22:43]

Description was changed from

==========
Rename OnError to OnErrorAdapter and OnSuccess to OnSucessAdapter.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |OnError| type and
an |onError| virtual method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |OnError| being the name of both the type and the method (with both
living in the same namespace). Similar situation happens for onSuccess /
OnSuccess names.

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480

Review-Url: https://codereview.chromium.org/2570193002
==========

to

==========
Rename OnError to OnErrorAdapter and OnSuccess to OnSucessAdapter.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |OnError| type and
an |onError| virtual method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |OnError| being the name of both the type and the method (with both
living in the same namespace). Similar situation happens for onSuccess /
OnSuccess names.

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480

Committed: https://crrev.com/18c69c35b756dca9096cf2fc0ab69d4b6d7ddba5
Cr-Commit-Position: refs/heads/master@{#438579}
==========

[commit-bot: I haz the power, 2016-12-14 19:22:43]

Patchset 1 (id:??) landed as
https://crrev.com/18c69c35b756dca9096cf2fc0ab69d4b6d7ddba5
Cr-Commit-Position: refs/heads/master@{#438579}