Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/protobuf/patches/0012-fix-overflow-FastUInt32ToBufferLeft.patch

Issue 2570123002: Fix integer overflow in FastUInt32ToBufferLeft (Closed)
Patch Set: CQ refresh Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/protobuf/README.chromium ('k') | third_party/protobuf/src/google/protobuf/stubs/strutil.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/patches/0012-fix-overflow-FastUInt32ToBufferLeft.patch
diff --git a/third_party/protobuf/patches/0012-fix-overflow-FastUInt32ToBufferLeft.patch b/third_party/protobuf/patches/0012-fix-overflow-FastUInt32ToBufferLeft.patch
new file mode 100644
index 0000000000000000000000000000000000000000..34d97eb311c379ffac4c90818616e1e42c874665
--- /dev/null
+++ b/third_party/protobuf/patches/0012-fix-overflow-FastUInt32ToBufferLeft.patch
@@ -0,0 +1,11 @@
+--- a/src/google/protobuf/stubs/strutil.cc
++++ b/src/google/protobuf/stubs/strutil.cc
+@@ -981,7 +981,7 @@ static const char two_ASCII_digits[100][2] = {
+ };
+
+ char* FastUInt32ToBufferLeft(uint32 u, char* buffer) {
+- int digits;
++ uint32 digits;
+ const char *ASCII_digits = NULL;
+ // The idea of this implementation is to trim the number of divides to as few
+ // as possible by using multiplication and subtraction rather than mod (%),
« no previous file with comments | « third_party/protobuf/README.chromium ('k') | third_party/protobuf/src/google/protobuf/stubs/strutil.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698