third_party/protobuf/patches/0012-fix-overflow-FastUInt32ToBufferLeft.patch - Issue 2570123002: Fix integer overflow in FastUInt32ToBufferLeft

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/protobuf/patches/0012-fix-overflow-FastUInt32ToBufferLeft.patch

Issue 2570123002: Fix integer overflow in FastUInt32ToBufferLeft (Closed)

Patch Set: CQ refresh Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 --- a/src/google/protobuf/stubs/strutil.cc

	2 +++ b/src/google/protobuf/stubs/strutil.cc

	3 @@ -981,7 +981,7 @@ static const char two_ASCII_digits[100][2] = {

	4 };

	5

	6 char* FastUInt32ToBufferLeft(uint32 u, char* buffer) {

	7 - int digits;

	8 + uint32 digits;

	9 const char *ASCII_digits = NULL;

	10 // The idea of this implementation is to trim the number of divides to as few

	11 // as possible by using multiplication and subtraction rather than mod (%),

OLD	NEW