Remove test suffixes from included filename in boilerplate.py.

Remove test suffixes from included filename in boilerplate.py.

When generating *_test.cc or *_unittest.cc, remove _test and _unittest suffix
from included header filename.

Committed: https://crrev.com/70c505377868e2702d09c5dad5d24bacd783791a
Cr-Commit-Position: refs/heads/master@{#438528}

[Bence, 2016-12-13 17:08:27]

bnc@chromium.org changed reviewers:
+ rsesek@chromium.org

[Bence, 2016-12-13 17:08:27]

Robert: PTAL.  Thank you.

[Robert Sesek, 2016-12-13 17:23:20]

Nice. One comment.

https://codereview.chromium.org/2570093002/diff/1/tools/boilerplate.py
File tools/boilerplate.py (right):

https://codereview.chromium.org/2570093002/diff/1/tools/boilerplate.py#newcode56
tools/boilerplate.py:56: if base[-5:] == '_test':
It may be easier to maintain something like this:

suffixes = [ '_test', '_unittest' ]
for suffix in suffixes:
  l = len(suffix)
  if base[-l:] == suffix:
    return base[:l]

... which means you could also add _browsertest easily.

[Bence, 2016-12-14 12:02:19]

PTAL.  Great idea, thank you.

https://codereview.chromium.org/2570093002/diff/1/tools/boilerplate.py
File tools/boilerplate.py (right):

https://codereview.chromium.org/2570093002/diff/1/tools/boilerplate.py#newcode56
tools/boilerplate.py:56: if base[-5:] == '_test':
On 2016/12/13 17:23:20, Robert Sesek wrote:
> It may be easier to maintain something like this:
> 
> suffixes = [ '_test', '_unittest' ]
> for suffix in suffixes:
>   l = len(suffix)
>   if base[-l:] == suffix:
>     return base[:l]
> 
> ... which means you could also add _browsertest easily.

Done.

[Robert Sesek, 2016-12-14 15:50:44]

LGTM

[Bence, 2016-12-14 16:11:56]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:12:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 16:28:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481731916608440,
"parent_rev": "a848762f100e4177399a90a7601668a24ec0449b", "commit_rev":
"932e87847f393f1409fb99e094dd8b821700f633"}

[commit-bot: I haz the power, 2016-12-14 16:28:42]

Description was changed from

==========
Remove test suffixes from included filename in boilerplate.py.

When generating *_test.cc or *_unittest.cc, remove _test and _unittest suffix
from included header filename.
==========

to

==========
Remove test suffixes from included filename in boilerplate.py.

When generating *_test.cc or *_unittest.cc, remove _test and _unittest suffix
from included header filename.

Review-Url: https://codereview.chromium.org/2570093002
==========

[commit-bot: I haz the power, 2016-12-14 16:28:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 16:30:29]

Description was changed from

==========
Remove test suffixes from included filename in boilerplate.py.

When generating *_test.cc or *_unittest.cc, remove _test and _unittest suffix
from included header filename.

Review-Url: https://codereview.chromium.org/2570093002
==========

to

==========
Remove test suffixes from included filename in boilerplate.py.

When generating *_test.cc or *_unittest.cc, remove _test and _unittest suffix
from included header filename.

Committed: https://crrev.com/70c505377868e2702d09c5dad5d24bacd783791a
Cr-Commit-Position: refs/heads/master@{#438528}
==========

[commit-bot: I haz the power, 2016-12-14 16:30:31]

Patchset 2 (id:??) landed as
https://crrev.com/70c505377868e2702d09c5dad5d24bacd783791a
Cr-Commit-Position: refs/heads/master@{#438528}