Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: build/config/ios/BUILD.gn

Issue 2570043002: [ios] Adds a buildflag for the ios_app_bundle_id_prefix. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/ios/BUILD.gn
diff --git a/build/config/ios/BUILD.gn b/build/config/ios/BUILD.gn
index 0dda3e52631cc9f627d1e9519501859bafa6a7a2..e11770c9b0b60e4bb0cd6f21904a59608ced693d 100644
--- a/build/config/ios/BUILD.gn
+++ b/build/config/ios/BUILD.gn
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/buildflag_header.gni")
import("//build/config/ios/ios_sdk.gni")
import("//build/config/sysroot.gni")
import("//build/toolchain/toolchain.gni")
@@ -64,3 +65,8 @@ config("xctest_config") {
group("xctest") {
public_configs = [ ":xctest_config" ]
}
+
+buildflag_header("ios_app_bundle_id_prefix_header") {
rohitrao (ping after 24h) 2016/12/13 14:14:30 Is this the right GN file for this header?
sdefresne 2016/12/13 15:18:02 I think it would be better in ios/chrome/common (a
rohitrao (ping after 24h) 2016/12/13 15:20:47 So I'll leave the variable in ios_sdk.gni but I'll
+ header = "ios_app_bundle_id_prefix.h"
+ flags = [ "IOS_APP_BUNDLE_ID_PREFIX=\"$ios_app_bundle_id_prefix\"" ]
+}
« no previous file with comments | « no previous file | ios/chrome/common/app_group/BUILD.gn » ('j') | ios/chrome/common/app_group/app_group_constants.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698