Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 import("//build/buildflag_header.gni") | |
| 5 import("//build/config/ios/ios_sdk.gni") | 6 import("//build/config/ios/ios_sdk.gni") |
| 6 import("//build/config/sysroot.gni") | 7 import("//build/config/sysroot.gni") |
| 7 import("//build/toolchain/toolchain.gni") | 8 import("//build/toolchain/toolchain.gni") |
| 8 | 9 |
| 9 # This is included by reference in the //build/config/compiler:runtime_library | 10 # This is included by reference in the //build/config/compiler:runtime_library |
| 10 # config that is applied to all targets. It is here to separate out the logic | 11 # config that is applied to all targets. It is here to separate out the logic |
| 11 # that is iOS-only. Please see that target for advice on what should go in | 12 # that is iOS-only. Please see that target for advice on what should go in |
| 12 # :runtime_library vs. :compiler. | 13 # :runtime_library vs. :compiler. |
| 13 config("runtime_library") { | 14 config("runtime_library") { |
| 14 common_flags = [ | 15 common_flags = [ |
| (...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 57 | 58 |
| 58 libs = [ | 59 libs = [ |
| 59 "Foundation.framework", | 60 "Foundation.framework", |
| 60 "XCTest.framework", | 61 "XCTest.framework", |
| 61 ] | 62 ] |
| 62 } | 63 } |
| 63 | 64 |
| 64 group("xctest") { | 65 group("xctest") { |
| 65 public_configs = [ ":xctest_config" ] | 66 public_configs = [ ":xctest_config" ] |
| 66 } | 67 } |
| 68 | |
| 69 buildflag_header("ios_app_bundle_id_prefix_header") { | |
|
rohitrao (ping after 24h)
2016/12/13 14:14:30
Is this the right GN file for this header?
sdefresne
2016/12/13 15:18:02
I think it would be better in ios/chrome/common (a
rohitrao (ping after 24h)
2016/12/13 15:20:47
So I'll leave the variable in ios_sdk.gni but I'll
| |
| 70 header = "ios_app_bundle_id_prefix.h" | |
| 71 flags = [ "IOS_APP_BUNDLE_ID_PREFIX=\"$ios_app_bundle_id_prefix\"" ] | |
| 72 } | |
| OLD | NEW |