Reland: ash: Use system tray mojo interface to show system update tray icon

Reland: ash: Use system tray mojo interface to show system update tray icon

crrev.com/2558043006 was reverted for compile failure in the official build.
I made a namespace mistake in a component updater file that is only compiled in
official builds.

Original description:
Change the flow so that Chrome explicitly asks ash to show the icon
rather than having ash ask Chrome whether there is an update available.

* Add ShowUpdateIcon to system_tray.mojom
* Introduce update.mojom
* Migrate ash to using ash::mojom::UpdateSeverity internally
* Migrate update methods from SystemTrayDelegate to SystemTrayClient
* Add a new SystemTrayClientTest and move existing Flash test there

Also add docs for SystemTrayItem (used by TrayUpdate) since tray view
vs. default view vs. detailed view always confuses me.

BUG=647412
TEST=chrome browser_tests, ash_unittests
TBR=msw@chromium.org

Committed: https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40
Cr-Commit-Position: refs/heads/master@{#438233}

[James Cook, 2016-12-13 17:33:35]

Description was changed from

==========
Reland: ash: Use system tray mojo interface to show system update tray icon

crrev.com/2558043006 was reverted for compile failure in the official build.
I made a namespace mistake in a component updater file that is only compiled in
official builds.

Original description:
Change the flow so that Chrome explicitly asks ash to show the icon
rather than having ash ask Chrome whether there is an update available.

* Add ShowUpdateIcon to system_tray.mojom
* Introduce update.mojom
* Migrate ash to using ash::mojom::UpdateSeverity internally
* Migrate update methods from SystemTrayDelegate to SystemTrayClient
* Add a new SystemTrayClientTest and move existing Flash test there

Also add docs for SystemTrayItem (used by TrayUpdate) since tray view
vs. default view vs. detailed view always confuses me.

BUG=647412
TEST=chrome browser_tests, ash_unittests
==========

to

==========
Reland: ash: Use system tray mojo interface to show system update tray icon

crrev.com/2558043006 was reverted for compile failure in the official build.
I made a namespace mistake in a component updater file that is only compiled in
official builds.

Original description:
Change the flow so that Chrome explicitly asks ash to show the icon
rather than having ash ask Chrome whether there is an update available.

* Add ShowUpdateIcon to system_tray.mojom
* Introduce update.mojom
* Migrate ash to using ash::mojom::UpdateSeverity internally
* Migrate update methods from SystemTrayDelegate to SystemTrayClient
* Add a new SystemTrayClientTest and move existing Flash test there

Also add docs for SystemTrayItem (used by TrayUpdate) since tray view
vs. default view vs. detailed view always confuses me.

BUG=647412
TEST=chrome browser_tests, ash_unittests
TBR=msw@chromium.org
==========

[James Cook, 2016-12-13 17:33:52]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-12-13 17:33:52]

TBR msw for fixing a namespace

[James Cook, 2016-12-13 17:33:56]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-12-13 17:34:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-12-13 17:52:50]

You should cite the previous issue in the cl desc, but lgtm

[msw, 2016-12-13 17:53:10]

Oh duh, you did, it just wasn't linkified :)

[commit-bot: I haz the power, 2016-12-13 18:35:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481650436503300,
"parent_rev": "0a5238acfe232932ae5aeb1346fe8b256b6f167b", "commit_rev":
"af76f141e86821b23cb6709e892720ada71f4f26"}

[commit-bot: I haz the power, 2016-12-13 18:36:02]

Description was changed from

==========
Reland: ash: Use system tray mojo interface to show system update tray icon

crrev.com/2558043006 was reverted for compile failure in the official build.
I made a namespace mistake in a component updater file that is only compiled in
official builds.

Original description:
Change the flow so that Chrome explicitly asks ash to show the icon
rather than having ash ask Chrome whether there is an update available.

* Add ShowUpdateIcon to system_tray.mojom
* Introduce update.mojom
* Migrate ash to using ash::mojom::UpdateSeverity internally
* Migrate update methods from SystemTrayDelegate to SystemTrayClient
* Add a new SystemTrayClientTest and move existing Flash test there

Also add docs for SystemTrayItem (used by TrayUpdate) since tray view
vs. default view vs. detailed view always confuses me.

BUG=647412
TEST=chrome browser_tests, ash_unittests
TBR=msw@chromium.org
==========

to

==========
Reland: ash: Use system tray mojo interface to show system update tray icon

crrev.com/2558043006 was reverted for compile failure in the official build.
I made a namespace mistake in a component updater file that is only compiled in
official builds.

Original description:
Change the flow so that Chrome explicitly asks ash to show the icon
rather than having ash ask Chrome whether there is an update available.

* Add ShowUpdateIcon to system_tray.mojom
* Introduce update.mojom
* Migrate ash to using ash::mojom::UpdateSeverity internally
* Migrate update methods from SystemTrayDelegate to SystemTrayClient
* Add a new SystemTrayClientTest and move existing Flash test there

Also add docs for SystemTrayItem (used by TrayUpdate) since tray view
vs. default view vs. detailed view always confuses me.

BUG=647412
TEST=chrome browser_tests, ash_unittests
TBR=msw@chromium.org

Review-Url: https://codereview.chromium.org/2570033004
==========

[commit-bot: I haz the power, 2016-12-13 18:36:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 18:39:42]

Description was changed from

==========
Reland: ash: Use system tray mojo interface to show system update tray icon

crrev.com/2558043006 was reverted for compile failure in the official build.
I made a namespace mistake in a component updater file that is only compiled in
official builds.

Original description:
Change the flow so that Chrome explicitly asks ash to show the icon
rather than having ash ask Chrome whether there is an update available.

* Add ShowUpdateIcon to system_tray.mojom
* Introduce update.mojom
* Migrate ash to using ash::mojom::UpdateSeverity internally
* Migrate update methods from SystemTrayDelegate to SystemTrayClient
* Add a new SystemTrayClientTest and move existing Flash test there

Also add docs for SystemTrayItem (used by TrayUpdate) since tray view
vs. default view vs. detailed view always confuses me.

BUG=647412
TEST=chrome browser_tests, ash_unittests
TBR=msw@chromium.org

Review-Url: https://codereview.chromium.org/2570033004
==========

to

==========
Reland: ash: Use system tray mojo interface to show system update tray icon

crrev.com/2558043006 was reverted for compile failure in the official build.
I made a namespace mistake in a component updater file that is only compiled in
official builds.

Original description:
Change the flow so that Chrome explicitly asks ash to show the icon
rather than having ash ask Chrome whether there is an update available.

* Add ShowUpdateIcon to system_tray.mojom
* Introduce update.mojom
* Migrate ash to using ash::mojom::UpdateSeverity internally
* Migrate update methods from SystemTrayDelegate to SystemTrayClient
* Add a new SystemTrayClientTest and move existing Flash test there

Also add docs for SystemTrayItem (used by TrayUpdate) since tray view
vs. default view vs. detailed view always confuses me.

BUG=647412
TEST=chrome browser_tests, ash_unittests
TBR=msw@chromium.org

Committed: https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40
Cr-Commit-Position: refs/heads/master@{#438233}
==========

[commit-bot: I haz the power, 2016-12-13 18:39:43]

Patchset 2 (id:??) landed as
https://crrev.com/8054778c11c1a356d7588fa7d96b1964b68acc40
Cr-Commit-Position: refs/heads/master@{#438233}