Update chrome/browser/prerender/OWNERS

Update chrome/browser/prerender/OWNERS

Committed: https://crrev.com/9537f0377898ee2402b86ea1f28b663c4a01a0f7
Cr-Commit-Position: refs/heads/master@{#439078}

[droger, 2016-12-13 12:27:43]

droger@chromium.org changed reviewers:
+ pasko@chromium.org

[droger, 2016-12-13 12:27:44]

pasko: for review
mmenke FYI

[mmenke, 2016-12-13 15:56:55]

On 2016/12/13 12:27:44, droger wrote:
> pasko: for review
> mmenke FYI

Should the old owners be removed?  (Gavin certainly should, as he hasn't worked
on prerender in like 5 years, less sure about david and I)

[droger, 2016-12-13 16:18:58]

On 2016/12/13 15:56:55, mmenke wrote:
> On 2016/12/13 12:27:44, droger wrote:
> > pasko: for review
> > mmenke FYI
> 
> Should the old owners be removed?  (Gavin certainly should, as he hasn't
worked
> on prerender in like 5 years, less sure about david and I)

I was thinking we could keep you around for a bit longer, but I can remove you.
Let me know what you prefer.

[droger, 2016-12-13 16:19:17]

CC davidben

[pasko, 2016-12-13 17:31:38]

I think gavinp,mmenke,davidben should decide for themselves whether they want to
be occasionally targeted with codereviews in prerender. Non-trivial codereviews
would be nice to forward to droger/pasko/mattcary, of course, at least as an
FYI.

I think there is value in having one of the folks from that side of the Atlantic
Ocean, at least for trivial reviews originating from that side of the Ocean, but
I would not be too upset if you guys all opt out.

https://codereview.chromium.org/2570013002/diff/1/chrome/browser/prerender/OW...
File chrome/browser/prerender/OWNERS (right):

https://codereview.chromium.org/2570013002/diff/1/chrome/browser/prerender/OW...
chrome/browser/prerender/OWNERS:4: mattcary@chromium.org
do we allow OWNERS that are not committers yet?

Even if we do, it would be better to list here only people who can actually
formally approve the change.

[davidben, 2016-12-13 18:17:14]

On 2016/12/13 17:31:38, pasko wrote:
> I think gavinp,mmenke,davidben should decide for themselves whether they want
to
> be occasionally targeted with codereviews in prerender. Non-trivial
codereviews
> would be nice to forward to droger/pasko/mattcary, of course, at least as an
> FYI.
> 
> I think there is value in having one of the folks from that side of the
Atlantic
> Ocean, at least for trivial reviews originating from that side of the Ocean,
but
> I would not be too upset if you guys all opt out.

At this point, my familiarity with this code is pretty slim. It's not been very
high-traffic, so I also don't mind staying on here if it's useful, but if you
all are familiar with and actively working on the code now, it might be best for
reviews to go your way anyway.

[pasko, 2016-12-13 18:22:30]

On 2016/12/13 18:17:14, davidben wrote:
> On 2016/12/13 17:31:38, pasko wrote:
> > I think gavinp,mmenke,davidben should decide for themselves whether they
want
> to
> > be occasionally targeted with codereviews in prerender. Non-trivial
> codereviews
> > would be nice to forward to droger/pasko/mattcary, of course, at least as an
> > FYI.
> > 
> > I think there is value in having one of the folks from that side of the
> Atlantic
> > Ocean, at least for trivial reviews originating from that side of the Ocean,
> but
> > I would not be too upset if you guys all opt out.
> 
> At this point, my familiarity with this code is pretty slim. It's not been
very
> high-traffic, so I also don't mind staying on here if it's useful, but if you
> all are familiar with and actively working on the code now, it might be best
for
> reviews to go your way anyway.

yeah, it makes _some_ sense for you to approve small/trivial changes if you can
do that while we are sleeping, and redirect to us in other cases, but it seems
that there are not many cases like this flying around, so I'm totally OK to
handle all ownership in PAR.

[droger, 2016-12-15 16:41:26]

Indeed, per policy, owners have to be full committers, so mattcary will have to
wait a bit more.

There was no clear-cut decision regarding mmenke and davidben, so leaving them
there for now, and I guess we'll revisit this file when/if mattcary is added.

[pasko, 2016-12-15 17:19:49]

lgtm

[droger, 2016-12-16 09:36:14]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2016-12-16 09:36:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 09:48:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481880974132320,
"parent_rev": "6cb8e0e31547df4bacc67e0dbc3ca244dd3cc6a1", "commit_rev":
"a62af02df00a5d61bf2f8a23f1f6e10877c637c2"}

[commit-bot: I haz the power, 2016-12-16 09:49:05]

Description was changed from

==========
Update chrome/browser/prerender/OWNERS
==========

to

==========
Update chrome/browser/prerender/OWNERS

Review-Url: https://codereview.chromium.org/2570013002
==========

[commit-bot: I haz the power, 2016-12-16 09:49:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-16 09:50:43]

Description was changed from

==========
Update chrome/browser/prerender/OWNERS

Review-Url: https://codereview.chromium.org/2570013002
==========

to

==========
Update chrome/browser/prerender/OWNERS

Committed: https://crrev.com/9537f0377898ee2402b86ea1f28b663c4a01a0f7
Cr-Commit-Position: refs/heads/master@{#439078}
==========

[commit-bot: I haz the power, 2016-12-16 09:50:44]

Patchset 2 (id:??) landed as
https://crrev.com/9537f0377898ee2402b86ea1f28b663c4a01a0f7
Cr-Commit-Position: refs/heads/master@{#439078}