Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 25700006: Disable re-running of ContentShell commands on windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 0a2e31f0b87ace1f4a8eeac8f432a85349e6eec0..cb9de965995f306e38660440e7db8d2679ac0b84 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -2173,13 +2173,6 @@ bool shouldRetryCommand(CommandOutput output) {
} else if (command is SeleniumTestCommand) {
// Selenium tests can be flaky. Try re-running.
return true;
- } else if (command is ContentShellCommand) {
kasperl 2013/10/03 11:14:22 Nice to get rid of this.
- // FIXME(kustermann): Remove this condition once we figured out why
- // content_shell is sometimes not able to fetch resources from the
- // HttpServer on windows.
- // TODO(kustermann): Don't blindly re-run DRT tests on windows but rather
- // check if the stderr/stdout indicates that we actually have this issue.
- return io.Platform.operatingSystem == 'windows';
}
}
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698