Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file |
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
| 4 | 4 |
| 5 /** | 5 /** |
| 6 * Classes and methods for executing tests. | 6 * Classes and methods for executing tests. |
| 7 * | 7 * |
| 8 * This module includes: | 8 * This module includes: |
| 9 * - Managing parallel execution of tests, including timeout checks. | 9 * - Managing parallel execution of tests, including timeout checks. |
| 10 * - Evaluating the output of each test as pass/fail/crash/timeout. | 10 * - Evaluating the output of each test as pass/fail/crash/timeout. |
| (...skipping 2155 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2166 } | 2166 } |
| 2167 } | 2167 } |
| 2168 | 2168 |
| 2169 if (command is BrowserTestCommand) { | 2169 if (command is BrowserTestCommand) { |
| 2170 // We do not re-run tests on the new browser controller, since it should | 2170 // We do not re-run tests on the new browser controller, since it should |
| 2171 // not be as flaky as selenium. | 2171 // not be as flaky as selenium. |
| 2172 return false; | 2172 return false; |
| 2173 } else if (command is SeleniumTestCommand) { | 2173 } else if (command is SeleniumTestCommand) { |
| 2174 // Selenium tests can be flaky. Try re-running. | 2174 // Selenium tests can be flaky. Try re-running. |
| 2175 return true; | 2175 return true; |
| 2176 } else if (command is ContentShellCommand) { | |
|
kasperl
2013/10/03 11:14:22
Nice to get rid of this.
| |
| 2177 // FIXME(kustermann): Remove this condition once we figured out why | |
| 2178 // content_shell is sometimes not able to fetch resources from the | |
| 2179 // HttpServer on windows. | |
| 2180 // TODO(kustermann): Don't blindly re-run DRT tests on windows but rather | |
| 2181 // check if the stderr/stdout indicates that we actually have this issue. | |
| 2182 return io.Platform.operatingSystem == 'windows'; | |
| 2183 } | 2176 } |
| 2184 } | 2177 } |
| 2185 return false; | 2178 return false; |
| 2186 } | 2179 } |
| 2187 | 2180 |
| 2188 /* | 2181 /* |
| 2189 * [TestCaseCompleter] will listen for | 2182 * [TestCaseCompleter] will listen for |
| 2190 * NodeState.Processing -> NodeState.{Successfull,Failed} state changes and | 2183 * NodeState.Processing -> NodeState.{Successfull,Failed} state changes and |
| 2191 * will complete a TestCase if it is finished. | 2184 * will complete a TestCase if it is finished. |
| 2192 * | 2185 * |
| (...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2373 } | 2366 } |
| 2374 } | 2367 } |
| 2375 | 2368 |
| 2376 void eventAllTestsDone() { | 2369 void eventAllTestsDone() { |
| 2377 for (var listener in _eventListener) { | 2370 for (var listener in _eventListener) { |
| 2378 listener.allDone(); | 2371 listener.allDone(); |
| 2379 } | 2372 } |
| 2380 _allDone(); | 2373 _allDone(); |
| 2381 } | 2374 } |
| 2382 } | 2375 } |
| OLD | NEW |