Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIPort.idl

Issue 2569993003: Low risk non-nullable => nullable change (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webmidi/MIDIPort.idl
diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIPort.idl b/third_party/WebKit/Source/modules/webmidi/MIDIPort.idl
index d3523bfb9ea9ee449f11f453fe06637ca94c1cc7..e88f6ae10de8059a9971239391d6c631166a706c 100644
--- a/third_party/WebKit/Source/modules/webmidi/MIDIPort.idl
+++ b/third_party/WebKit/Source/modules/webmidi/MIDIPort.idl
@@ -58,11 +58,11 @@ enum MIDIPortType {
] interface MIDIPort : EventTarget {
readonly attribute MIDIPortConnectionState connection;
readonly attribute DOMString id;
- readonly attribute DOMString manufacturer;
- readonly attribute DOMString name;
+ readonly attribute DOMString? manufacturer;
foolip 2016/12/13 22:37:31 Oh my, I've lied again. This would change the gene
+ readonly attribute DOMString? name;
readonly attribute MIDIPortDeviceState state;
readonly attribute MIDIPortType type;
- readonly attribute DOMString version;
+ readonly attribute DOMString? version;
attribute EventHandler onstatechange;

Powered by Google App Engine
This is Rietveld 408576698