Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.idl

Issue 2569993003: Low risk non-nullable => nullable change (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.idl
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.idl b/third_party/WebKit/Source/core/html/HTMLInputElement.idl
index 669c8e19aa5d3d984cf719d87fa4aa9e324c7342..c2c5587f44013ea0e13f59c4140e3afef2c20b31 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.idl
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.idl
@@ -80,9 +80,9 @@ interface HTMLInputElement : HTMLElement {
void select();
// FIXME: selectionStart and selectionEnd should be unsigned long.
- [RaisesException, ImplementedAs=selectionStartForBinding] attribute long selectionStart;
- [RaisesException, ImplementedAs=selectionEndForBinding] attribute long selectionEnd;
- [RaisesException, ImplementedAs=selectionDirectionForBinding] attribute DOMString selectionDirection;
+ [RaisesException, ImplementedAs=selectionStartForBinding] attribute long? selectionStart;
foolip 2016/12/13 22:37:31 OK, so I said that making readonly attributes null
lunalu1 2016/12/14 11:00:14 Done.
+ [RaisesException, ImplementedAs=selectionEndForBinding] attribute long? selectionEnd;
+ [RaisesException, ImplementedAs=selectionDirectionForBinding] attribute DOMString? selectionDirection;
[RaisesException] void setRangeText(DOMString replacement);
[RaisesException] void setRangeText(DOMString replacement,
unsigned long start,

Powered by Google App Engine
This is Rietveld 408576698