Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2569983003: PreParsing inner funcs: Remove nonsense code from PreParser. (Closed)

Created:
4 years ago by marja
Modified:
4 years ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PreParsing inner funcs: Remove nonsense code from PreParser. The assignment in default parameters (e.g., function foo(a = somedefault) { } doesn't flow through PreParserFactory::NewAssignment even if the comment claims so. Thus, piping through the variables is not needed. Kudos to neis@ for pointing this out. BUG=v8:5501 R=neis@chromium.org Committed: https://crrev.com/0c827cd00030664fc3bdba0dd5284760873a39a7 Cr-Commit-Position: refs/heads/master@{#41670}

Patch Set 1 #

Patch Set 2 : more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
M src/parsing/preparser.h View 2 chunks +3 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 3 chunks +47 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
marja
ptal I might need to add this when I start declaring inner function params in ...
4 years ago (2016-12-13 10:17:47 UTC) #3
neis
lgtm, thanks.
4 years ago (2016-12-13 12:22:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569983003/20001
4 years ago (2016-12-13 12:32:23 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 12:34:25 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-13 12:35:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c827cd00030664fc3bdba0dd5284760873a39a7
Cr-Commit-Position: refs/heads/master@{#41670}

Powered by Google App Engine
This is Rietveld 408576698