Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Issue 2569963003: Remove DOMWindowProperty from PresentationController (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DOMWindowProperty from PresentationController We're deprecating DOMWindowProperty, which is now equivalent to ContextLifecycleObserver. This CL replaces DOMWindowProperty with ContextLifecycleObserver in PresentationController. BUG=610176 Committed: https://crrev.com/3006a20fcf89e17a112edcc3e7b33c7cacf9accf Cr-Commit-Position: refs/heads/master@{#438114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/modules/presentation/PresentationController.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationController.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
4 years ago (2016-12-13 07:56:40 UTC) #2
sof
lgtm
4 years ago (2016-12-13 08:29:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569963003/1
4 years ago (2016-12-13 08:44:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 10:16:56 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-13 10:18:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3006a20fcf89e17a112edcc3e7b33c7cacf9accf
Cr-Commit-Position: refs/heads/master@{#438114}

Powered by Google App Engine
This is Rietveld 408576698