Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2569953002: Removes example code that isn't correctly wired up (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes example code that isn't correctly wired up In particular the session code going to ash isn't really wired up correctly. As we don't plan on using this soon I'm going to remove it for now. We can bring back when necessary. R=ben@chromium.org BUG=none Committed: https://crrev.com/d102cee18fdb86d2e94c1eeaf4333741363256f4 Cr-Commit-Position: refs/heads/master@{#438160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1083 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/window_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/window_manager.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M ash/mus/window_manager_application.h View 4 chunks +1 line, -14 lines 0 comments Download
M ash/mus/window_manager_application.cc View 2 chunks +1 line, -12 lines 0 comments Download
M chrome/app/mash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/mash/chrome_mash_content_browser_manifest_overlay.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/mash/mash_runner.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mash/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/example/window_type_launcher/manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 6 chunks +0 lines, -31 lines 0 comments Download
D mash/init/BUILD.gn View 1 chunk +0 lines, -39 lines 0 comments Download
D mash/init/init.h View 1 chunk +0 lines, -64 lines 0 comments Download
D mash/init/init.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D mash/init/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mash/init/manifest.json View 1 chunk +0 lines, -19 lines 0 comments Download
D mash/init/public/interfaces/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D mash/init/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D mash/init/public/interfaces/constants.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
D mash/init/public/interfaces/init.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D mash/login/BUILD.gn View 1 chunk +0 lines, -45 lines 0 comments Download
D mash/login/login.h View 1 chunk +0 lines, -20 lines 0 comments Download
D mash/login/login.cc View 1 chunk +0 lines, -219 lines 0 comments Download
D mash/login/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mash/login/manifest.json View 1 chunk +0 lines, -17 lines 0 comments Download
D mash/login/public/interfaces/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D mash/login/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D mash/login/public/interfaces/constants.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
D mash/login/public/interfaces/login.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D mash/screenlock/BUILD.gn View 1 chunk +0 lines, -44 lines 0 comments Download
D mash/screenlock/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mash/screenlock/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
D mash/screenlock/public/interfaces/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D mash/screenlock/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D mash/screenlock/public/interfaces/constants.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
D mash/screenlock/screenlock.h View 1 chunk +0 lines, -51 lines 0 comments Download
D mash/screenlock/screenlock.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M mash/session/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M mash/session/manifest.json View 1 chunk +0 lines, -3 lines 0 comments Download
M mash/session/public/interfaces/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
D mash/session/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D mash/session/public/interfaces/session.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
M mash/session/session.h View 4 chunks +1 line, -22 lines 0 comments Download
M mash/session/session.cc View 4 chunks +1 line, -68 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
sky
4 years ago (2016-12-13 04:38:39 UTC) #1
Ben Goodger (Google)
lgtm. tho i wonder if you should be building any of //mash anymore... let that ...
4 years ago (2016-12-13 05:08:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569953002/1
4 years ago (2016-12-13 14:07:53 UTC) #8
sky
On 2016/12/13 05:08:56, Ben Goodger (Google) wrote: > lgtm. tho i wonder if you should ...
4 years ago (2016-12-13 14:08:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 14:12:14 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 14:14:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d102cee18fdb86d2e94c1eeaf4333741363256f4
Cr-Commit-Position: refs/heads/master@{#438160}

Powered by Google App Engine
This is Rietveld 408576698