Updated time picker to use new clock UI format

Updated time picker to use new clock UI format

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353
Committed: https://crrev.com/fabb27e978e8a3805bd4f15173bcc31d71528892
Cr-Commit-Position: refs/heads/master@{#438988}

[shaktisahu, 2016-12-14 19:53:50]

Description was changed from

==========
Updated time picker to use new clock UI format

For setting time in an webpage (<input type=time>), clank currently
displayes a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353
==========

to

==========
Updated date and time pickers to use new calendar/clock UI format

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

For setting both date and time (<input type=datetime, datetime-local>),
currently spinners are displayed in a single dialog to set both date
and time. This CL will change it to show two separate dialog, a calendar
followed by a clock UI. Having both the dialogs in a single page would
have been desired but it is not possible due to scrolling issues
in nested scroll views.

BUG=541353
==========

[shaktisahu, 2016-12-14 19:55:43]

shaktisahu@chromium.org changed reviewers:
+ tedchoc@chromium.org

[shaktisahu, 2016-12-14 19:55:43]

tedchoc@ - PTAL

[Ted C, 2016-12-14 21:50:16]

On 2016/12/14 19:55:43, shaktisahu wrote:
> tedchoc@ - PTAL

Can we split this into two changes?

One for input type=time and then a follow up for the datetime case.

I'd like to discuss that a bit more on the bug before we go with two
separate dialogs.  While this might be the best option, in my mind,
it seems preferable to have both within the same dialog, but not
on the same screen to avoid the scroll issues.  I'm thinking of
a next/back two screen-y thing.

But I don't want to block the initial time change on that discussion.

[Ted C, 2016-12-14 21:50:50]

On 2016/12/14 21:50:16, Ted C wrote:
> On 2016/12/14 19:55:43, shaktisahu wrote:
> > tedchoc@ - PTAL
> 
> Can we split this into two changes?
> 
> One for input type=time and then a follow up for the datetime case.
> 
> I'd like to discuss that a bit more on the bug before we go with two
> separate dialogs.  While this might be the best option, in my mind,
> it seems preferable to have both within the same dialog, but not
> on the same screen to avoid the scroll issues.  I'm thinking of
> a next/back two screen-y thing.
> 
> But I don't want to block the initial time change on that discussion.

Can you upload a screen capture/video to the bug of the two dialog
implementation?  That would probably make it easier to say yay-nay
to.

[shaktisahu, 2016-12-14 22:29:18]

Description was changed from

==========
Updated date and time pickers to use new calendar/clock UI format

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

For setting both date and time (<input type=datetime, datetime-local>),
currently spinners are displayed in a single dialog to set both date
and time. This CL will change it to show two separate dialog, a calendar
followed by a clock UI. Having both the dialogs in a single page would
have been desired but it is not possible due to scrolling issues
in nested scroll views.

BUG=541353
==========

to

==========
Updated time picker to use new clock UI format

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353
==========

[shaktisahu, 2016-12-14 22:31:28]

Description was changed from

==========
Updated time picker to use new clock UI format

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353
==========

to

==========
Updated time picker to use new clock UI format

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353
==========

[shaktisahu, 2016-12-14 22:34:15]

On 2016/12/14 21:50:50, Ted C wrote:
> On 2016/12/14 21:50:16, Ted C wrote:
> > On 2016/12/14 19:55:43, shaktisahu wrote:
> > > tedchoc@ - PTAL
> > 
> > Can we split this into two changes?
> > 
> > One for input type=time and then a follow up for the datetime case.
> > 
> > I'd like to discuss that a bit more on the bug before we go with two
> > separate dialogs.  While this might be the best option, in my mind,
> > it seems preferable to have both within the same dialog, but not
> > on the same screen to avoid the scroll issues.  I'm thinking of
> > a next/back two screen-y thing.
> > 
> > But I don't want to block the initial time change on that discussion.
> 
> Can you upload a screen capture/video to the bug of the two dialog
> implementation?  That would probably make it easier to say yay-nay
> to.

Okay, I changed this issue to contain changes for input type=time.
I will upload a separate CL for the  input type=datetime case. Also uploaded a
screen video on the bug.

[Ted C, 2016-12-16 00:12:34]

lgtm thanks!

[shaktisahu, 2016-12-16 01:04:04]

The CQ bit was checked by shaktisahu@chromium.org

[commit-bot: I haz the power, 2016-12-16 01:05:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 02:18:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481850244090560,
"parent_rev": "9e16575758daa8327d6928e3c61c115f5fb5667d", "commit_rev":
"4b02220b85e6051cbc6b178401b5d836bd958059"}

[commit-bot: I haz the power, 2016-12-16 02:19:02]

Description was changed from

==========
Updated time picker to use new clock UI format

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353
==========

to

==========
Updated time picker to use new clock UI format

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353

Review-Url: https://codereview.chromium.org/2569943002
==========

[commit-bot: I haz the power, 2016-12-16 02:19:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-16 02:21:04]

Description was changed from

==========
Updated time picker to use new clock UI format

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353

Review-Url: https://codereview.chromium.org/2569943002
==========

to

==========
Updated time picker to use new clock UI format

For setting time in an webpage (<input type=time>), clank currently
displays a spinner to set the time. This CL updates it to show the
standard clock UI provided by android. However the clock UI doesn't
have precision for seconds and milliseconds. In those cases, the
multi-field spinner will be displayed.

BUG=541353

Committed: https://crrev.com/fabb27e978e8a3805bd4f15173bcc31d71528892
Cr-Commit-Position: refs/heads/master@{#438988}
==========

[commit-bot: I haz the power, 2016-12-16 02:21:05]

Patchset 3 (id:??) landed as
https://crrev.com/fabb27e978e8a3805bd4f15173bcc31d71528892
Cr-Commit-Position: refs/heads/master@{#438988}