OffscreenCanvasCompositorFrameSink uses CompositorFrameSinkSupport

OffscreenCanvasCompositorFrameSink uses CompositorFrameSinkSupport

This CL is a mechanical refactor to transition
OffscreenCanvasCompositorFrameSink to use CompositorFrameSinkSupport,
enabling it to share code today with Mus and Exo.

BUG=664547
Committed: https://crrev.com/d5db7e2580f918cbbaab7b39deddd3e9344946b8
Cr-Commit-Position: refs/heads/master@{#438566}

[Fady Samuel, 2016-12-14 16:12:56]

Description was changed from

==========
WIP: OffscreenCanvasCompositorFrameSink uses CompositorFrameSinkSupport

BUG=
==========

to

==========
OffscreenCanvasCompositorFrameSink uses CompositorFrameSinkSupport

This CL is a mechanical refactor to transition 
OffscreenCanvasCompositorFrameSink to use CompositorFrameSinkSupport, 
enabling it to share code today with Mus and Exo.

BUG=664547
==========

[Fady Samuel, 2016-12-14 16:13:04]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 16:13:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-12-14 16:14:47]

fsamuel@chromium.org changed reviewers:
+ xlai@chromium.org

[Fady Samuel, 2016-12-14 16:14:47]

PTAL Olivia! Thanks!

[Fady Samuel, 2016-12-14 16:14:58]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 16:15:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xlai (Olivia), 2016-12-14 16:58:56]

https://codereview.chromium.org/2569923004/diff/40001/content/browser/rendere...
File
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc
(right):

https://codereview.chromium.org/2569923004/diff/40001/content/browser/rendere...
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc:28:
const cc::SurfaceId& surface_id,
I have one concern here. The SurfaceId is provided when CompositorFrameSink is
created; but your patch drops the LocalFrameId component. Will it be right if
CompositorFrameSinkProvider::CreateCompositorFrameSink only passes FrameSinkId,
and the LocalFrameId is only passed in SubmitCompositorFrame?

[Fady Samuel, 2016-12-14 17:00:23]

https://codereview.chromium.org/2569923004/diff/40001/content/browser/rendere...
File
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc
(right):

https://codereview.chromium.org/2569923004/diff/40001/content/browser/rendere...
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc:28:
const cc::SurfaceId& surface_id,
On 2016/12/14 16:58:56, xlai (Olivia) wrote:
> I have one concern here. The SurfaceId is provided when CompositorFrameSink is
> created; but your patch drops the LocalFrameId component. Will it be right if
> CompositorFrameSinkProvider::CreateCompositorFrameSink only passes
FrameSinkId,
> and the LocalFrameId is only passed in SubmitCompositorFrame?

Yes, that should be fine.

[commit-bot: I haz the power, 2016-12-14 17:06:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:06:10]

Dry run: This issue passed the CQ dry run.

[xlai (Olivia), 2016-12-14 17:41:47]

On 2016/12/14 17:00:23, Fady Samuel wrote:
>
https://codereview.chromium.org/2569923004/diff/40001/content/browser/rendere...
> File
>
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc
> (right):
> 
>
https://codereview.chromium.org/2569923004/diff/40001/content/browser/rendere...
>
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc:28:
> const cc::SurfaceId& surface_id,
> On 2016/12/14 16:58:56, xlai (Olivia) wrote:
> > I have one concern here. The SurfaceId is provided when CompositorFrameSink
is
> > created; but your patch drops the LocalFrameId component. Will it be right
if
> > CompositorFrameSinkProvider::CreateCompositorFrameSink only passes
> FrameSinkId,
> > and the LocalFrameId is only passed in SubmitCompositorFrame?
> 
> Yes, that should be fine.

lgtm

[Fady Samuel, 2016-12-14 17:43:15]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-12-14 17:43:15]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2016-12-14 17:43:16]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:43:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 19:01:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481737396683680,
"parent_rev": "0b08ff42b56b0bed7d360cdc54df3d7556f325c6", "commit_rev":
"d6762a685139c1576d9b9d9546c1d83228c3ac89"}

[commit-bot: I haz the power, 2016-12-14 19:05:28]

Description was changed from

==========
OffscreenCanvasCompositorFrameSink uses CompositorFrameSinkSupport

This CL is a mechanical refactor to transition 
OffscreenCanvasCompositorFrameSink to use CompositorFrameSinkSupport, 
enabling it to share code today with Mus and Exo.

BUG=664547
==========

to

==========
OffscreenCanvasCompositorFrameSink uses CompositorFrameSinkSupport

This CL is a mechanical refactor to transition
OffscreenCanvasCompositorFrameSink to use CompositorFrameSinkSupport,
enabling it to share code today with Mus and Exo.

BUG=664547

Committed: https://crrev.com/d5db7e2580f918cbbaab7b39deddd3e9344946b8
Cr-Commit-Position: refs/heads/master@{#438566}
==========

[commit-bot: I haz the power, 2016-12-14 19:05:29]

Patchset 3 (id:??) landed as
https://crrev.com/d5db7e2580f918cbbaab7b39deddd3e9344946b8
Cr-Commit-Position: refs/heads/master@{#438566}