OffscreenCanvasCompositorFrameSink uses CompositorFrameSinkSupport

content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc

Index: content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc
diff --git a/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc b/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc
index 65a174944696856a370152760e2d7ce3a7ee7af6..d5877e31b63723977b339e6e67583ca02b87de56 100644
--- a/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc
+++ b/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.cc
@@ -4,6 +4,7 @@
 
 #include "content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.h"
 
+#include "content/browser/compositor/surface_utils.h"
 #include "content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 
@@ -27,8 +28,9 @@ void OffscreenCanvasCompositorFrameSinkProviderImpl::CreateCompositorFrameSink(
     const cc::SurfaceId& surface_id,

[xlai (Olivia), 2016/12/14 16:58:56]

I have one concern here. The SurfaceId is provided when CompositorFrameSink is
created; but your patch drops the LocalFrameId component. Will it be right if
CompositorFrameSinkProvider::CreateCompositorFrameSink only passes FrameSinkId,
and the LocalFrameId is only passed in SubmitCompositorFrame?

[Fady Samuel, 2016/12/14 17:00:23]

Yes, that should be fine.

     cc::mojom::MojoCompositorFrameSinkClientPtr client,
     cc::mojom::MojoCompositorFrameSinkRequest request) {
-  OffscreenCanvasCompositorFrameSink::Create(surface_id, std::move(client),
-                                             std::move(request));
+  OffscreenCanvasCompositorFrameSink::Create(
+      surface_id.frame_sink_id(), GetSurfaceManager(), std::move(client),
+      std::move(request));
 }
 
 }  // namespace content