Refer back to Jinja templates from the C++ code generated from IDL files.

Refer back to Jinja templates from the C++ code generated from IDL files.

After the changes, the generated code
(e.g. out/gn/gen/blink/core/dom/TouchInit.h)
will contain a comment similar to:

    // This file has been generated from the Jinja2 template in
    // third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

BUG=673936
Committed: https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707
Cr-Commit-Position: refs/heads/master@{#438690}

[haraken, 2016-12-14 01:16:45]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-12-14 01:16:45]

LGTM

[Yuki, 2016-12-14 10:36:42]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2016-12-14 10:36:42]

LGTM.

[peria, 2016-12-14 10:42:06]

peria@chromium.org changed reviewers:
+ peria@chromium.org

[peria, 2016-12-14 10:42:06]

lgtm

[Łukasz Anforowicz, 2016-12-14 17:14:25]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 17:14:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-12-14 17:37:12]

Thank you for the reviews.

In patchset #2, I am also updating expectations of run-bindings-tests.  The
update is pretty straightforward (as expected there are 3 new lines everywhere),
except that self-reviewing the updated test expectations uncovered one case
where I did not set jinja_template_filename.  I've updated this one case
(code_generator_web_module.py) in patchset #3.

The changes in patchset #2 and #3 are a fairly mechanical follow-up and so I
assume don't require another round of reviews - I'll push this CL to CQ in an
hour or so.

PS. My appologies for not running run-bindings-tests earlier - I first wanted to
get feedback on the overall direction this CL (thanks for taking a look).

PPS. I've also tried double-checking that there are no more empty comments (what
happened previously with code_generator_web_module.py), by looking at all the
generated comments via:
$ cd out/gn/gen
$ for i in `ag 'from the Jinja2' -l`; do head -9 $i | tail -1; done | sort |
uniq
// third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
// third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl
// third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
// third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
// third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl
// third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl
// third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl
// third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl
// third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
// third_party/WebKit/Source/bindings/templates/interface.h.tmpl
// third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl
// third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl
// third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl
// third_party/WebKit/Source/bindings/templates/union_container.h.tmpl

[commit-bot: I haz the power, 2016-12-14 17:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:47:10]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[haraken, 2016-12-14 23:47:10]

still LGTM

[Łukasz Anforowicz, 2016-12-14 23:49:29]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-12-14 23:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from peria@chromium.org,
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2569923003/#ps40001
(title: "Also cover templates used from code_generator_web_module.py")

[commit-bot: I haz the power, 2016-12-14 23:50:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 01:05:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481759369085530,
"parent_rev": "0dee5c134e8c2b2c4dee435dfc47ccc0a3f558a5", "commit_rev":
"908785cc7f323e882d87d29d2e6067bc9f7a90a1"}

[commit-bot: I haz the power, 2016-12-15 01:06:52]

Description was changed from

==========
Refer back to Jinja templates from the C++ code generated from IDL files.

After the changes, the generated code
(e.g. out/gn/gen/blink/core/dom/TouchInit.h)
will contain a comment similar to:

    // This file has been generated from the Jinja2 template in
    // third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

BUG=673936
==========

to

==========
Refer back to Jinja templates from the C++ code generated from IDL files.

After the changes, the generated code
(e.g. out/gn/gen/blink/core/dom/TouchInit.h)
will contain a comment similar to:

    // This file has been generated from the Jinja2 template in
    // third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

BUG=673936

Review-Url: https://codereview.chromium.org/2569923003
==========

[commit-bot: I haz the power, 2016-12-15 01:06:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 01:11:45]

Description was changed from

==========
Refer back to Jinja templates from the C++ code generated from IDL files.

After the changes, the generated code
(e.g. out/gn/gen/blink/core/dom/TouchInit.h)
will contain a comment similar to:

    // This file has been generated from the Jinja2 template in
    // third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

BUG=673936

Review-Url: https://codereview.chromium.org/2569923003
==========

to

==========
Refer back to Jinja templates from the C++ code generated from IDL files.

After the changes, the generated code
(e.g. out/gn/gen/blink/core/dom/TouchInit.h)
will contain a comment similar to:

    // This file has been generated from the Jinja2 template in
    // third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

BUG=673936

Committed: https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707
Cr-Commit-Position: refs/heads/master@{#438690}
==========

[commit-bot: I haz the power, 2016-12-15 01:11:46]

Patchset 3 (id:??) landed as
https://crrev.com/fccd34e5adef51e73c5c2eabecaf71419a891707
Cr-Commit-Position: refs/heads/master@{#438690}

[peria, 2016-12-15 02:24:08]

lgtm