Chromium Code Reviews

Issue 2569923002: Split Buffer into WriteBuffer/ReadBuffer. (Closed)

Created:
4 years ago by iannucci
Modified:
4 years ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+47 lines, -37 lines)
M service/datastore/serialize/invertible.go View 3 chunks +27 lines, -17 lines 0 comments
M service/datastore/serialize/serialize.go View 17 chunks +19 lines, -19 lines 0 comments
M service/datastore/serialize/serialize_test.go View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 13 (8 generated)
iannucci
4 years ago (2016-12-13 03:04:37 UTC) #1
iannucci
PTAL
4 years ago (2016-12-13 03:09:58 UTC) #6
dnj
lgtm
4 years ago (2016-12-13 03:11:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569923002/1
4 years ago (2016-12-13 03:11:36 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 03:16:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/ac70e96219aebdd26608395df0d7f8b41b15771d

Powered by Google App Engine