Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2569913002:
Refactor AnimatedStyleBuilder.cpp (Closed)
|
Created:
4 years ago by alancutter (OOO until 2018) Modified:
4 years ago CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactor AnimatedStyleBuilder.cpp
Refactor helper functions for https://codereview.chromium.org/2562643002.
BUG=267316
Committed: https://crrev.com/8169999824ac8b859cc936344c9fe33ad3ab7450
Cr-Commit-Position: refs/heads/master@{#438735}
Patch Set 1 #Patch Set 2 : Finish patch #
Dependent Patchsets: Messages
Total messages: 20 (10 generated)
Description was changed from ========== AnimatedStyleBuilder Refactor helper functions for https://codereview.chromium.org/2562643002. ========== to ========== Refactor AnimatedStyleBuilder.cpp Refactor helper functions for https://codereview.chromium.org/2562643002. ==========
alancutter@chromium.org changed reviewers: + suzyh@chromium.org
lgtm Add bug number to description?
Description was changed from ========== Refactor AnimatedStyleBuilder.cpp Refactor helper functions for https://codereview.chromium.org/2562643002. ========== to ========== Refactor AnimatedStyleBuilder.cpp Refactor helper functions for https://codereview.chromium.org/2562643002. BUG=267316 ==========
The CQ bit was checked by alancutter@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
alancutter@chromium.org changed reviewers: + timloh@chromium.org - suzyh@chromium.org
+timloh for core/css.
lgtm
The CQ bit was checked by alancutter@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481775368830990,
"parent_rev": "557c31586281496c9b476ba59eff6a55c6dea974", "commit_rev":
"6f7bfc03ac29efc1ff0018fc9a7dae06c90e68ea"}
Message was sent while issue was closed.
Description was changed from ========== Refactor AnimatedStyleBuilder.cpp Refactor helper functions for https://codereview.chromium.org/2562643002. BUG=267316 ========== to ========== Refactor AnimatedStyleBuilder.cpp Refactor helper functions for https://codereview.chromium.org/2562643002. BUG=267316 Review-Url: https://codereview.chromium.org/2569913002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Refactor AnimatedStyleBuilder.cpp Refactor helper functions for https://codereview.chromium.org/2562643002. BUG=267316 Review-Url: https://codereview.chromium.org/2569913002 ========== to ========== Refactor AnimatedStyleBuilder.cpp Refactor helper functions for https://codereview.chromium.org/2562643002. BUG=267316 Committed: https://crrev.com/8169999824ac8b859cc936344c9fe33ad3ab7450 Cr-Commit-Position: refs/heads/master@{#438735} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8169999824ac8b859cc936344c9fe33ad3ab7450 Cr-Commit-Position: refs/heads/master@{#438735} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
