Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2569893002: Do not show tab title when it is not needed (Closed)

Created:
4 years ago by mdjones
Modified:
4 years ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not show tab title when it is not needed This change passes whether or not a tab's title is needed to native code. This is necessary because the title creation logic was moved from Java in https://codereview.chromium.org/2320623003/. Previously, If a title was not created in the Java layer, querying for it would simply return null and a title would not be displayed. Since the creation logic was moved, querying for the title will create it if it doesn't already exist. BUG=673283 Committed: https://crrev.com/10d027d94197314f91c124e9d04c2b7c3701d280 Cr-Commit-Position: refs/heads/master@{#438889}

Patch Set 1 #

Patch Set 2 : remove extra new line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mdjones
ptal
4 years ago (2016-12-12 22:36:53 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years ago (2016-12-14 18:53:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569893002/20001
4 years ago (2016-12-15 18:42:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 19:18:20 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-15 19:20:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10d027d94197314f91c124e9d04c2b7c3701d280
Cr-Commit-Position: refs/heads/master@{#438889}

Powered by Google App Engine
This is Rietveld 408576698