Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2569883003: Fallback to null sink moved from WebMediaPlayer to WebAudioSourceProvider::Initialize(), so that we… (Closed)

Created:
4 years ago by o1ka
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fallback to null sink moved from WebMediaPlayer to WebAudioSourceProvider::Initialize(), so that we do it on media thread. UMA stats for AudioOutputDevice status and for fallbacks to null sink. BUG=668506, 668201, 663546, 626862, 673291 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=dalecurtis@chromium.org,dcheng@chromium.org,holte@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2533443002 Cr-Commit-Position: refs/heads/master@{#436614} (cherry picked from commit e4ba2ed8354d01411848143efbe8d17b41e1853b) Review-Url: https://codereview.chromium.org/2569883003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -56 lines) Patch
M content/common/media/audio_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/html_audio_element_capturer_source_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/audio_output_device.cc View 1 chunk +4 lines, -1 line 0 comments Download
M media/audio/null_audio_sink.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/output_device_info.h View 1 chunk +4 lines, -1 line 0 comments Download
M media/blink/webaudiosourceprovider_impl.h View 4 chunks +10 lines, -4 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.cc View 8 chunks +46 lines, -13 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl_unittest.cc View 9 chunks +96 lines, -25 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569883003/1
4 years ago (2016-12-13 11:59:51 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-13 12:04:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698