Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2569863005: Move getBufferSubDataAsync to an extension (Closed)
Patch Set: fixup Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
index 88e7a1c35e98c9261c63136c8d5c054e29d2e61c..b2d07a276c2a4c45cc753b57b66564f8cab6d023 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
@@ -5,7 +5,6 @@
#ifndef WebGL2RenderingContextBase_h
#define WebGL2RenderingContextBase_h
-#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/TraceWrapperMember.h"
#include "modules/webgl/WebGLExtension.h"
#include "modules/webgl/WebGLRenderingContextBase.h"
@@ -17,6 +16,7 @@ class WebGLTexture;
class WebGLActiveInfo;
class WebGLBuffer;
+class WebGLGetBufferSubDataAsync;
class WebGLGetBufferSubDataAsyncCallback;
class WebGLProgram;
class WebGLQuery;
@@ -46,12 +46,6 @@ class WebGL2RenderingContextBase : public WebGLRenderingContextBase {
void copyBufferSubData(GLenum, GLenum, long long, long long, long long);
void getBufferSubData(GLenum, long long, DOMArrayBufferView*, GLuint, GLuint);
- ScriptPromise getBufferSubDataAsync(ScriptState*,
- GLenum target,
- GLintptr srcByteOffset,
- DOMArrayBufferView*,
- GLuint dstOffset,
- GLuint length);
void registerGetBufferSubDataAsyncCallback(
WebGLGetBufferSubDataAsyncCallback*);
@@ -747,6 +741,7 @@ class WebGL2RenderingContextBase : public WebGLRenderingContextBase {
protected:
friend class V8WebGL2RenderingContext;
+ friend class WebGLGetBufferSubDataAsync;
WebGL2RenderingContextBase(
HTMLCanvasElement*,

Powered by Google App Engine
This is Rietveld 408576698