[Cronet] Remove deprecated UrlRequestException.

[Cronet] Remove deprecated UrlRequestException.

BUG=629299
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2569863002
Cr-Commit-Position: refs/heads/master@{#442035}
Committed: https://chromium.googlesource.com/chromium/src/+/11de1da8c40a44352104c72ef0fec7cbdc170686

[mef, 2016-12-12 21:01:18]

Description was changed from

==========
[Cronet] Remove deprecated UrlRequestException.

BUG=629299
==========

to

==========
[Cronet] Remove deprecated UrlRequestException.

BUG=629299
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mef, 2016-12-12 21:01:38]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 21:03:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-12-12 21:54:48]

mef@chromium.org changed reviewers:
+ pauljensen@chromium.org

[mef, 2016-12-12 21:54:49]

Hi Paul, PTAL.

No rush, as I'm not planning to land this until we switch to M57 and all apps
use CronetException.

[commit-bot: I haz the power, 2016-12-13 01:58:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:58:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pauljensen, 2016-12-13 12:59:56]

Looks good, but you need to update cronet/README.md

[mef, 2017-01-04 15:27:49]

On 2016/12/13 12:59:56, pauljensen wrote:
> Looks good, but you need to update cronet/README.md

Done, PTAL. Most of the callers have been switched to CronetException, so we
should be able to land this soon.

[pauljensen, 2017-01-04 18:25:33]

lgtm

[mef, 2017-01-04 18:32:03]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 18:32:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 19:48:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 19:48:03]

Dry run: This issue passed the CQ dry run.

[mef, 2017-01-06 16:32:50]

The CQ bit was checked by mef@chromium.org

[mef, 2017-01-06 16:32:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
pauljensen@chromium.org
Link to the patchset: https://codereview.chromium.org/2569863002/#ps60001
(title: "Sync")

[commit-bot: I haz the power, 2017-01-06 16:33:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 16:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 16:46:42]

Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[mef, 2017-01-06 17:42:17]

On 2017/01/06 16:46:42, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_cronet on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

Paul, it fails because of API removal:

----------
mef@mefz:~/chrome/android/src$ components/cronet/tools/update_api.py --api_jar
/usr/local/google/home/mef/chrome/android/src/out/Debug/lib.java/components/cronet/android/cronet_api.jar
ERROR: This API was modified or removed:
             public void onFailed(org.chromium.net.UrlRequest,
org.chromium.net.UrlResponseInfo, org.chromium.net.CronetException);

       Cronet API methods and classes cannot be modified.
----------

Any idea on how to make it happy?

[pauljensen, 2017-01-06 17:59:43]

Can you manually delete the onFailed() line from
components/cronet/android/api.txt and increment
components/cronet/android/api_version.txt (perhaps with "echo -n 2 >
api_version.txt"?

[mef, 2017-01-06 18:12:02]

On 2017/01/06 17:59:43, pauljensen wrote:
> Can you manually delete the onFailed() line from
> components/cronet/android/api.txt and increment
> components/cronet/android/api_version.txt (perhaps with "echo -n 2 >
> api_version.txt"?

PTAL. I've done that (see Patch Set 5) but it didn't help:

$ components/cronet/tools/update_api.py --api_jar
/usr/local/google/home/mef/chrome/android/src/out/Debug/lib.java/components/cronet/android/cronet_api.jar
ERROR: This API was modified or removed:
             public void onFailed(org.chromium.net.UrlRequest,
org.chromium.net.UrlResponseInfo, org.chromium.net.CronetException);

       Cronet API methods and classes cannot be modified.

[pauljensen, 2017-01-06 18:13:36]

Don't run update_api.py, you updated the API by hand, so you don't need to use
the script to do it.  The script won't let you make breaking changes like this.

[mef, 2017-01-06 18:19:28]

On 2017/01/06 18:13:36, pauljensen wrote:
> Don't run update_api.py, you updated the API by hand, so you don't need to use
> the script to do it.  The script won't let you make breaking changes like
this.

I see, sgtm, PTAL if current change makes sense to you.

[mef, 2017-01-06 18:19:35]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 18:19:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pauljensen, 2017-01-06 18:20:30]

lgtm

[commit-bot: I haz the power, 2017-01-06 18:34:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 18:34:25]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[mef, 2017-01-06 18:53:58]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 18:54:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2017-01-06 18:54:53]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 18:55:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2017-01-06 19:56:13]

The CQ bit was unchecked by mef@chromium.org

[mef, 2017-01-06 19:56:24]

The CQ bit was checked by mef@chromium.org

[mef, 2017-01-06 19:56:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
pauljensen@chromium.org
Link to the patchset: https://codereview.chromium.org/2569863002/#ps100001
(title: "Update api.txt")

[commit-bot: I haz the power, 2017-01-06 19:56:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:38:41]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1483732584108020,
"parent_rev": "151280976aad5ebe2285cf1b446e98ea9635600c", "commit_rev":
"11de1da8c40a44352104c72ef0fec7cbdc170686"}

[commit-bot: I haz the power, 2017-01-06 20:39:12]

Description was changed from

==========
[Cronet] Remove deprecated UrlRequestException.

BUG=629299
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Remove deprecated UrlRequestException.

BUG=629299
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2569863002
Cr-Commit-Position: refs/heads/master@{#442035}
Committed:
https://chromium.googlesource.com/chromium/src/+/11de1da8c40a44352104c72ef0fe...
==========

[commit-bot: I haz the power, 2017-01-06 20:39:13]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/11de1da8c40a44352104c72ef0fe...