Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2569843004: Revert of [gpu_tests] Disable flaky pixel tests (Closed)

Created:
4 years ago by Ken Russell (switch to Gerrit)
Modified:
4 years ago
Reviewers:
nednguyen
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [gpu_tests] Disable flaky pixel tests (patchset #1 id:1 of https://codereview.chromium.org/2569013005/ ) Reason for revert: These tests failed catastrophically three times on December 9 on Windows and Mac OS. The runs all timed out. If this had been persistent, I'd be worried and would agree with this disabling -- but looking again, they've failed once on December 11 and once on December 12. Disabling them wholesale is unwarranted. Original issue's description: > [gpu_tests] Disable flaky pixel tests > > BUG=672999 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > TBR=kbr@chromium.org,zmo@chromium.org > > Committed: https://crrev.com/e3e722f67a0b233f7291532478516434a6fe3bcb > Cr-Commit-Position: refs/heads/master@{#438166} TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672999 Committed: https://crrev.com/b4d5b9ad484224745b4780b1f828dab6cf0fd9f7 Cr-Commit-Position: refs/heads/master@{#438273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ken Russell (switch to Gerrit)
Created Revert of [gpu_tests] Disable flaky pixel tests
4 years ago (2016-12-13 20:11:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569843004/1
4 years ago (2016-12-13 20:11:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 20:13:07 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 20:17:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4d5b9ad484224745b4780b1f828dab6cf0fd9f7
Cr-Commit-Position: refs/heads/master@{#438273}

Powered by Google App Engine
This is Rietveld 408576698